Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change smoke to use String instead of Symbol #17863

Closed
sigmundch opened this issue Mar 27, 2014 · 8 comments
Closed

change smoke to use String instead of Symbol #17863

sigmundch opened this issue Mar 27, 2014 · 8 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@sigmundch
Copy link
Member

Strings are easier to use and faster than symbol (e.g. lookup in tables), and if the only purpose of symbol is for dart:mirrors, we could change smoke to hide them under the smoke/mirrors.dart implementation.

In that case, should we also be changing package:observe and other packages to use String instead of symbol?
@sigmundch
Copy link
Member Author

Added Pkg-Smoke label.

@jmesserly
Copy link

Removed Area-Polymer label.
Added Area-Pkg label.

@sigmundch
Copy link
Member Author

Added this to the 1.6 milestone.

@sigmundch
Copy link
Member Author

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member Author

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member Author

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member Author

Removed Polymer-Milestone-Next label.

@sigmundch sigmundch added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 9, 2014
@DartBot DartBot mentioned this issue Jun 4, 2015
Open
@DartBot
Copy link

DartBot commented Jun 4, 2015

This issue has been moved to dart-archive/smoke#7.

@DartBot DartBot closed this as completed Jun 4, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @jmesserly @sigmundch @DartBot