Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't implicitly add "lib" to library root #17751

Closed
munificent opened this issue Mar 24, 2014 · 3 comments
Closed

Don't implicitly add "lib" to library root #17751

munificent opened this issue Mar 24, 2014 · 3 comments
Assignees
@johnniwinther
Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug web-dart2js

Comments

@munificent
Copy link
Member

Dart2js takes a "library root" that it uses to locate files in the Dart SDK. This is the path to the root directory of the SDK. It then automatically adds "lib" to that to get the actual library root.

In pub, we're doing some work to make source maps for the core Dart libraries work. This means including those libraries in the build/serve output (in a debug build only, of course). We're doing that by placing them in a fake package. Since all public assets in a package live in "lib", the SDK sources are in "$sdk/lib". Then dart2js adds its own lib, so we end up with "$sdk/lib/lib", which is kind of ugly.

It would be nice if the library root we pass to dart2js was the path to the actual "lib" directory itself and dart2js didn't implicitly tack "lib" on to the end of it.
@floitschG
Copy link
Contributor

cc @johnniwinther.
Added Triaged label.

@johnniwinther
Copy link
Member

Set owner to @johnniwinther.
Added Accepted label.

@munificent
Copy link
Member Author

Thanks for a taking a look!

If you end up changing this, please run the pub tests and make sure the source map ones stay happy. If you need help synchronizing any pub changes, let me know.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Feb 29, 2016
@sigmundch sigmundch added the closed-not-planned Closed as we don't intend to take action on the reported issue label Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnniwinther johnniwinther

Labels
closed-not-planned Closed as we don't intend to take action on the reported issue type-enhancement A request for a change that isn't a bug web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @munificent @sigmundch @floitschG @johnniwinther