Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pub's check for entry points is too narrow #17543

Closed
blois opened this issue Mar 17, 2014 · 3 comments
Closed

Pub's check for entry points is too narrow #17543

blois opened this issue Mar 17, 2014 · 3 comments

Comments

@blois
Copy link
Contributor

blois commented Mar 17, 2014

Currently dart2js within pub only treats files as entry points if they have a main() method in that file, this misses cases where the main is from an exported lib and where the main is in a part.
@nex3
Copy link
Member

nex3 commented Mar 17, 2014

Removed Pub-Build label.

@nex3
Copy link
Member

nex3 commented Mar 17, 2014

Right now we determine whether a file is an entrypoint in [isPrimary], which has advantages in terms of logging and quickly determining the transformer graph. Fixing this would mean that entrypoint detection would need access to secondary inputs, and thus couldn't occur in [isPrimary].

One possibility is that [isPrimary] considers any Dart file with an export or part statement to be primary and then does further checking in [apply].

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#926.

@DartBot DartBot closed this as completed Jun 5, 2015
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nex3 @kevmoo @blois @DartBot