Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-only transformers are unnecessarily loaded #17534

Closed
blois opened this issue Mar 17, 2014 · 6 comments
Closed

Test-only transformers are unnecessarily loaded #17534

blois opened this issue Mar 17, 2014 · 6 comments
Assignees
@nex3
Labels
type-enhancement A request for a change that isn't a bug

Comments

@blois
Copy link

blois commented Mar 17, 2014

Looking at pub build for Angular, I see that it's spending about 10s loading transformers for DI, but DI is only using transformers for tests.

DI uses $include: test/auto_injector_test.dart to only apply to tests.

I would expect that it could be skipped entirely.
@nex3
Copy link
Member

nex3 commented Mar 17, 2014

Are these transformers declared in dev_transformers?

@nex3
Copy link
Member

nex3 commented Mar 17, 2014

Looks like we haven't added support for those yet! I'm re-targeting this issue to be about them.

Removed Pub-Build label.
Changed the title to: "Add dev_transformers that are only loaded if the package is the entrypoint package".

@munificent
Copy link
Member

Removed Type-Defect label.
Added Type-Enhancement label.

@nex3
Copy link
Member

nex3 commented Jul 1, 2014

Now that we already have logic in pub for optimizing based on $include/$exclude, I feel more comfortable leaving these transformers out based solely on those grounds. That also makes it clearer how entrypoint-only transformers interact with normal transformers.

Set owner to @nex3.
Added Started label.
Changed the title to: "Test-only transformers are unnecessarily loaded".

@nex3
Copy link
Member

nex3 commented Jul 2, 2014

Fixed in r37925.

Added Fixed label.

@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#925.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nex3 nex3

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nex3 @kevmoo @munificent @blois @DartBot