Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsolateSpawnException should expose more metadata #17501

Closed
nex3 opened this issue Mar 14, 2014 · 7 comments
Closed

IsolateSpawnException should expose more metadata #17501

nex3 opened this issue Mar 14, 2014 · 7 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug

Comments

@nex3
Copy link
Member

nex3 commented Mar 14, 2014

Currently, IsolateSpawnException only exposes a [toString] method (which is poorly formatted -- see issue #12689). This makes it very difficult to report isolate errors, such as those from "pub serve", in a user-friendly manner.

For an error caused by a library failing to load, it would be useful to have, in order of descending usefulness:

* The URI of the library that failed to load.

  • The URIs of libraries that transitively imported that library.
  • The line and position of each of those import statements.
  • Information about the HTTP or filesystem error that caused the library load to fail.
@lrhn
Copy link
Member

lrhn commented Mar 19, 2014

Added Area-Library label.

@nex3
Copy link
Member Author

nex3 commented Mar 25, 2014

Marked this as blocking #17200.

@nex3 nex3 added Type-Defect library-isolate area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Mar 25, 2014
This was referenced Jun 3, 2015
Closed
Open
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@kevmoo
Copy link
Member

kevmoo commented Feb 1, 2016

Er, blocking dart-lang/pub#896

@lrhn
Copy link
Member

lrhn commented Feb 9, 2016

This is not information that we can generally have. If dart2js fails to spawn an isolate, it's either because the JS files didn't exist or it had an error.

I think each platform should have a best-effort approach to reporting the errors, but it's not something we can generally add as fields of a the error.

@nex3
Copy link
Member Author

nex3 commented Feb 9, 2016

I'm fine if there are fields that are null in dart2js. But the VM at least has access to a bunch of information that we need, and the only way we're currently able to get it is by parsing strings, which means we get broken every so often when IsolateSpawnException.toString() changes.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@lrhn lrhn added type-enhancement A request for a change that isn't a bug and removed type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Jan 27, 2017
@lrhn lrhn added the core-m label Aug 11, 2017
@floitschG floitschG added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. and removed area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. core-m library-isolate labels Aug 25, 2017
@floitschG
Copy link
Contributor

Reassigning to VM.

This kind of information would need to come from the VM/embedder.

@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 22, 2018
@matanlurey
Copy link
Contributor

dart-lang/pub#896 is closed, so I assume we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nex3 @kevmoo @matanlurey @lrhn @floitschG