Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve integration of custom-elements in dart2js #17470

Closed
sigmundch opened this issue Mar 13, 2014 · 3 comments
Closed

improve integration of custom-elements in dart2js #17470

sigmundch opened this issue Mar 13, 2014 · 3 comments
Assignees
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@sigmundch
Copy link
Member

I run into a strange hint message about using mirrors in a program that doesn't use mirrors, but uses custom elements. Peter pointed out to me that this is because how custom elements are integrated with the dart2js piepeline.

If this can't be fixed that easily, can we fix the hint/warning?

Here is a simple example that reproduces the problem:

    import 'dart:html';
    class A extends HtmlElement { A.created() : super.created(); }
    main() => document.register('x-a', A);

Compiling this with dart2js generates the following (clearly misleading) warning:

    Hint: 3 methods retained for use by dart:mirrors out of 865 total methods (0%).

@sigmundch
Copy link
Member Author

Removed Priority-High label.
Added Priority-Unassigned label.

@karlklose
Copy link
Contributor

See also dartbug.com/17457 and https://codereview.chromium.org/196533014/.

@rakudrama
Copy link
Member

Fix in review https://codereview.chromium.org/340253003/


Set owner to @rakudrama.
Added Started label.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

4 participants