Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reported number of methods retained due to mirror usage is too high #17457

Closed
karlklose opened this issue Mar 13, 2014 · 2 comments
Closed
Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@karlklose
Copy link
Contributor

We calculate this number as #functions we have code for - #number of functions when the codegen queue is empty for the first time.

This means we include all methods that we generate after the queue closes as being due to mirrors.

We should either mark distinct phases in the codegen queue or explicitly count the methods we include for mirror usage.

@karlklose
Copy link
Contributor Author

Added Area-Dart2JS label.

@sigmundch sigmundch added the P3 A lower priority bug or feature request label Dec 11, 2015
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@bkonyi
Copy link
Contributor

bkonyi commented Jun 21, 2018

Since dart:mirrors is no longer supported on web, I'll assume this issue isn't relevant anymore.

@bkonyi bkonyi closed this as completed Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

4 participants