Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of IFrameElement is not valid #17456

Closed
DartBot opened this issue Mar 13, 2014 · 6 comments
Closed

Documentation of IFrameElement is not valid #17456

DartBot opened this issue Mar 13, 2014 · 6 comments
Labels
area-library closed-obsolete Closed as the reported issue is no longer relevant library-html type-documentation A request to add or improve documentation

Comments

@DartBot
Copy link

DartBot commented Mar 13, 2014

This issue was originally filed by alexe.kaigorodov@gmail.com


Though IFrameElement extends HtmlElement (and so Element), its behavour is different. For example, method setInnerHtml(String html) does not parse the html parameter, but converts it to Text. Thus,

  IFrameElement x = new IFrameElement();
  x.setInnerHtml('<div foo="foo"><bar id="bar"></bar></div>');
  var div = x.firstChild;
  print("div=${div.runtimeType} ${div.toString()}");

prints
  div=Text <div foo="foo"><bar id="bar"></bar></div>

But the documentation of the IFrameElement is simply inherited from HtmlElement and does not describe its specific features.

@sgjesse
Copy link
Contributor

sgjesse commented Mar 13, 2014

Added Area-HTML, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Mar 21, 2014

This comment was originally written by alexe.kaigorodov@gmail.com


Setter outerHtml is listed in the doc but not implemented

@DartBot
Copy link
Author

DartBot commented Mar 24, 2014

This comment was originally written by alexe.kaigorodov@gmail.com


IFrameElement.querySelector always return null.

@DartBot
Copy link
Author

DartBot commented Mar 26, 2014

This comment was originally written by alexe.kaigorodov@gmail.com


doc says: int tabIndex Gets/sets the position of the element in the tabbing order.

But attempt to set tabIndex causes runtime error:
Class 'IFrameElement' has no instance setter 'tabindex='.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@alan-knight
Copy link
Contributor

Assigning to doc for the main issue.

There are several others raised:
  - outerHtml is listed as final, so not settable, that's as expected
  - setting the tagIndex works for me in 1.8
  - querySelector does not seem to find child elements reproduces but I think it's intentional. At the moment we don't allow cross-frame access.


Removed Type-Defect label.
Added Type-Documentation label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-library closed-obsolete Closed as the reported issue is no longer relevant library-html type-documentation A request to add or improve documentation
Projects
None yet
Development

No branches or pull requests

5 participants