Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[next] Allow a single addEventListener target for all EventTarget subclasses #17408

Open
blois opened this issue Mar 11, 2014 · 3 comments
Open

[next] Allow a single addEventListener target for all EventTarget subclasses #17408

blois opened this issue Mar 11, 2014 · 3 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries

Comments

@blois
Copy link
Contributor

blois commented Mar 11, 2014

Currently we have multiple addEventListener functions for a number of EventTarget subclasses to do proper type casts on the C++ side when the C++ target class uses multiple inheritance.

This is problematic as we cannot have a single implementation of addEventListener in Dart code to do things such as wrapping in zones.
@blois
Copy link
Contributor Author

blois commented Mar 11, 2014

Marked this as blocking #17406.

@alan-knight
Copy link
Contributor

Might get addressed in the upcoming revision.

Changed the title to: "[next] Allow a single addEventListener target for all EventTarget subclasses".

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@rakudrama
Copy link
Member

A single addEventListener function (perhaps defined via a mixing everywhere) would benefit dart2js code generation by avoiding getInterceptor lookup when the receiver static type is EventListener.

@rakudrama rakudrama reopened this Mar 12, 2018
@terrylucas terrylucas added web-libraries Issues impacting dart:html, etc., libraries and removed area-dartium labels Jun 18, 2018
@matanlurey matanlurey added closed-obsolete Closed as the reported issue is no longer relevant and removed closed-obsolete Closed as the reported issue is no longer relevant labels Jun 21, 2018
@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @matanlurey @terrylucas @rakudrama @vsmenon @blois @alan-knight