Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liberal use of color by formatter #17356

Closed
DartBot opened this issue Mar 9, 2014 · 14 comments
Closed

liberal use of color by formatter #17356

DartBot opened this issue Mar 9, 2014 · 14 comments
Assignees
@scheglov
Milestone
1.9

Comments

@DartBot
Copy link

DartBot commented Mar 9, 2014

This issue was originally filed by @tatumizer

The program:
var x;
var y;
var z;

main() {
  print("hello");
}
foo() {
  print("foo");
}

  1. Select "main" function (complete body of it - from "main" to closing })
  2. Press CTRL-SHIFT-R
  3. It formats main, the body remains selected (blue), but additionally, identifier "foo" gets selected, too, and painted blue.
  4. Press CTRL-Z. It works with respect to prior formatting, but now the whole text of the program is blue, as if somebody pressed CTRL-A
@kasperl
Copy link

kasperl commented Mar 12, 2014

Added Area-Editor, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Mar 12, 2014

This comment was originally written by @tatumizer

BTW, CTRL-Z very often colors some (arbitrary?) fragment of code, which was never colored before. Apparently, the state of selection not properly memorized, and just made up instead.

@clayberg
Copy link

cc @scheglov.
Set owner to @pq.
Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@clayberg
Copy link

clayberg commented Apr 9, 2014

Set owner to @scheglov.
Removed this from the Later milestone.
Added this to the 1.4 milestone.

@scheglov
Copy link
Contributor

I can reproduce changing selection after formatting.
If you have any specific examples for other cases, please open separate issues.

Removed the owner.
Removed Area-Editor label.
Added Area-Formatter label.

@kasperl
Copy link

kasperl commented May 8, 2014

Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@munificent
Copy link
Member

Removed Area-Formatter label.
Added Area-Editor label.

@clayberg
Copy link

Set owner to @scheglov.

@scheglov
Copy link
Contributor

Editor should apply selections received from the formatter.
https://codereview.chromium.org/932423002

There are some issues in dart_style with computing selection after formatting.
See dart-lang/dart_style#175

Added Started label.

@scheglov
Copy link
Contributor

https://code.google.com/p/dart/source/detail?r=43918

Added Fixed label.

@clayberg
Copy link

Added this to the 1.9 milestone.

@DartBot DartBot added this to the 1.9 milestone Mar 25, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
None yet
Projects
None yet
Milestone
1.9
Development

No branches or pull requests
5 participants
@munificent @scheglov @kasperl @clayberg @DartBot