Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto package's SHA algorithm is slow #17317

Closed
devoncarew opened this issue Mar 6, 2014 · 2 comments
Closed

crypto package's SHA algorithm is slow #17317

devoncarew opened this issue Mar 6, 2014 · 2 comments
Assignees
@iposva-google
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@devoncarew
Copy link
Member

The SHA implementation seems slower then it should be. I created some benchmarks here:

https://github.com/devoncarew/sha_benchmark.dart

the benchmark numbers are here:

https://github.com/devoncarew/sha_benchmark.dart/blob/master/lib/sha_bench.dart#L8

I added benchmarks for a pure-dart implementation of inflate and deflate, to have something to compare SHA to. The SHA implementation seems about an order magnitude slower. Spark's git implementation is fairly slow, and we seem to be spending a lot of our time generating SHAs. It would be great to have this sped up a bit; not sure if there's some low-hanging fruit in the implementation.
@iposva-google
Copy link
Contributor

I'll take a quick look at the implementation. After a quick glance there might be some inefficiencies...

cc @sgmitrovic.
Set owner to @iposva-google.
Added Area-Pkg, Pkg-Crypto, Accepted labels.

@devoncarew devoncarew added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Mar 8, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/crypto#8.

@DartBot DartBot closed this as completed Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iposva-google iposva-google

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @devoncarew @iposva-google @DartBot