Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] window.performance.getEntries() returns a List of null entries #17250

Closed
alxhub opened this issue Mar 3, 2014 · 17 comments
Closed

[next] window.performance.getEntries() returns a List of null entries #17250

alxhub opened this issue Mar 3, 2014 · 17 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@alxhub
Copy link

alxhub commented Mar 3, 2014

What steps will reproduce the problem?

Call window.performance.getEntries()

What is the expected output? What do you see instead?

It should return a List<PerformanceEntry> with appropriate records.

Instead, it returns a List with the correct number of values, but they're all null.

@cbracken
Copy link
Member

cbracken commented Mar 3, 2014

Thanks - can you add SDK/Dartium version?


cc @jacob314.

@cbracken
Copy link
Member

cbracken commented Mar 3, 2014

cc @blois.

@blois
Copy link
Contributor

blois commented Mar 3, 2014

Is this blocking anything? Otherwise it's probably lower priority.

@blois
Copy link
Contributor

blois commented Mar 3, 2014

cc @efortuna.
Added this to the 1.3 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium, Area-HTML labels.

@iposva-google
Copy link
Contributor

Added Triaged label.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@efortuna
Copy link
Contributor

note: getEntries is an experimental API


Removed this from the 1.3 milestone.
Added this to the Later milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@alan-knight
Copy link
Contributor

Hoping this will be fixed in the next rev that Terry's working on.


Changed the title to: "[next] window.performance.getEntries() returns a List of null entries".

@alxhub alxhub added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Jan 13, 2015
@donny-dont
Copy link

@alan-knight I'm still seeing issues with this. This would be in 1.11.0-dev.5.2.

As a side question will the dart2js handle the case where its prefixed? Trying to run some stuff on a version of webkit where its webkitGetEntries.

@alan-knight
Copy link
Contributor

I've been out for a couple of weeks, and still not back in the office, not sure if Terry's stuff has landed yet. @terrylucas

Dart2js should in general handle the case of different prefixes. If it doesn't handle that specific case it should be just a matter of adding the variations to a list in the appropriate script.

@alan-knight
Copy link
Contributor

Can you try a simple test to see if it works prefixed, and if it doesn't, make a separate bug for that?

@donny-dont
Copy link

@alan-knight should I write a test within the sdk and do a pull request?

@alan-knight
Copy link
Contributor

That would be awesome. Assuming that the prefixed webkit version is in our test matrix.

@donny-dont
Copy link

It was failing in Chrome when compiled to JS.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Mar 1, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
@dustinlessard-wf
Copy link

This seems to also be an issue in Dart2. The following code was tested in DartPad on Dart SDK 2.0.0

import 'dart:html';

void triggerLongTask(Duration duration) {
      final startTime = new DateTime.now();
      while (new DateTime.now().difference(startTime) < duration) {}
    }

void main() {
  triggerLongTask(new Duration(seconds:2));
  List<PerformanceEntry> entries = window.performance.getEntries();
  for(var entry in entries){
    if(entry == null){
      print('entry is null');
    }
    else{
      print(entry.entryType);
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests