New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] window.performance.getEntries() returns a List of null entries #17250
Comments
Thanks - can you add SDK/Dartium version? cc @jacob314. |
cc @blois. |
Is this blocking anything? Otherwise it's probably lower priority. |
cc @efortuna. |
Added Triaged label. |
Removed Area-HTML label. |
Removed this from the Later milestone. |
Removed Oldschool-Milestone-Later label. |
Hoping this will be fixed in the next rev that Terry's working on. Changed the title to: "[next] window.performance.getEntries() returns a List of null entries". |
@alan-knight I'm still seeing issues with this. This would be in 1.11.0-dev.5.2. As a side question will the dart2js handle the case where its prefixed? Trying to run some stuff on a version of webkit where its webkitGetEntries. |
I've been out for a couple of weeks, and still not back in the office, not sure if Terry's stuff has landed yet. @terrylucas Dart2js should in general handle the case of different prefixes. If it doesn't handle that specific case it should be just a matter of adding the variations to a list in the appropriate script. |
Can you try a simple test to see if it works prefixed, and if it doesn't, make a separate bug for that? |
@alan-knight should I write a test within the sdk and do a pull request? |
That would be awesome. Assuming that the prefixed webkit version is in our test matrix. |
It was failing in Chrome when compiled to JS. |
This seems to also be an issue in Dart2. The following code was tested in DartPad on Dart SDK 2.0.0 import 'dart:html';
void triggerLongTask(Duration duration) {
final startTime = new DateTime.now();
while (new DateTime.now().difference(startTime) < duration) {}
}
void main() {
triggerLongTask(new Duration(seconds:2));
List<PerformanceEntry> entries = window.performance.getEntries();
for(var entry in entries){
if(entry == null){
print('entry is null');
}
else{
print(entry.entryType);
}
}
}
|
What steps will reproduce the problem?
Call window.performance.getEntries()
What is the expected output? What do you see instead?
It should return a List<PerformanceEntry> with appropriate records.
Instead, it returns a List with the correct number of values, but they're all null.
The text was updated successfully, but these errors were encountered: