Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formatter should add line breaks in constructor with long parameter list #17240

Closed
DartBot opened this issue Mar 3, 2014 · 12 comments
Closed

formatter should add line breaks in constructor with long parameter list #17240

DartBot opened this issue Mar 3, 2014 · 12 comments
Assignees
@pq
Labels
closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Mar 3, 2014

This issue was originally filed by @zoechi

What steps will reproduce the problem?
1.
I had this constructor in my class

  const
      Config(this.host, this.port, this.user, this.password, this.connectionPoolSize, this.schemaName, this.modelSchemaName, this.generatedCodePath);

2.
formatter breaks only after 'const'
it should break within the parameter list too.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
Dart VM version: 1.3.0-dev.0.1 (Thu Feb 27 08:23:24 2014) on "linux_x64"

Please provide any additional information below.
@iposva-google
Copy link
Contributor

Added Area-Formatter, Triaged labels.

@clayberg
Copy link

clayberg commented Mar 4, 2014

Added this to the 1.3 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@clayberg
Copy link

clayberg commented Mar 4, 2014

Set owner to @pq.

@pq
Copy link
Member

pq commented Apr 9, 2014

Removed this from the 1.3 milestone.
Added this to the 1.4 milestone.

@pq
Copy link
Member

pq commented Apr 9, 2014

Removed Type-Defect label.
Added Type-Enhancement label.

@kevmoo
Copy link
Member

kevmoo commented Apr 27, 2014

Marked this as blocking #16327.

@kasperl
Copy link

kasperl commented May 8, 2014

Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@munificent
Copy link
Member

Added AssumedStale label.

@DartBot DartBot added Type-Enhancement closed-obsolete Closed as the reported issue is no longer relevant labels Feb 13, 2015
This was referenced Jun 5, 2015
Closed
Closed
Closed
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/dart_style#330.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @munificent @pq @kasperl @iposva-google @clayberg @DartBot