New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blank lines confuse debugging experience #17206
Comments
We are displaying the source that dartium gives us for the indicated script. This source is a believe reconstituted from dart source from a snapshot. So, the dartdoc comments are not available. We could try and map the srcipt URL to a dart: source in the SDK. This is an issue with that however, in that there's no clear mapping from the script url to files in the sdk. The SDK files look like they're concatenated from lots of smaller dart file (e.g., svg_dartium.dart). And some libraries - dom/src/shared_html.dart - are not in the sdk at all. "url":"file:///Volumes/data/b/build/slave/dartium-mac-full-dev/build/src/dart/tools/dom/src/shared_html.dart" Not sure what the best solution to this is. If we had a clear mapping from script URLs to files in the SDK, we could use those. So, the script URLs could be something like "dart:html/dartium/html_dartium.dart". cc @a-siva. |
How about just collapsing the lines of white space down to one for each range? If we can't show the comments, we can at least improve the presentation in the Editor. Set owner to @devoncarew. |
I don't think the solution to this issue lies in the editor. As per my above comment, we need a better way to map from urls reported by dartium to source code located in the SDK. |
cc @devoncarew. |
Issue #19339 has been merged into this issue. |
Set owner to @jacob314. |
Comments are stripped from the core libraries in Dartium to reduce file size so there isn't really anything I can do. Keeping the snapshot size small seems like the right tradeoff given the importance of keeping startup time low. I agree the right solution is for the editor to show its version of the source file that includes the comments for "dart:" files. Set owner to @devoncarew. |
Removed this from the 1.7 milestone. |
Jacob, how can Editor get "its version" of dart:async-patch/timer_patch.dart file? |
https://codereview.chromium.org/598383004/ With this CL we will be able to show html_dartium.dart from SDK, with comments, semantic highlighting, navigation, etc. |
When debugging I suddenly ran into generated source code with multiple blank lines (see screenshot).
It might be a VM issue but the experience is extremely confusing and it should be corrected.
//Lars
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.3.0.dev_00_00 (2014-02-26)
OS: Linux - amd64 (3.2.5-gg1336)
JVM: 1.7.0-google-v5
projects: 11
open dart files: 19
auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 1778 / 890 / 450 MB
thread count: 45
index: 363274 relationships in 76053 keys in 587 sources
SDK installed: true
Dartium installed: true
Attachment:
screenshot.png (163.16 KB)
The text was updated successfully, but these errors were encountered: