Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages when transformer plugins fail to load #17200

Closed
yjbanov opened this issue Feb 28, 2014 · 9 comments
Closed

Improve error messages when transformer plugins fail to load #17200

yjbanov opened this issue Feb 28, 2014 · 9 comments

Comments

@yjbanov
Copy link

yjbanov commented Feb 28, 2014

What steps will reproduce the problem?

  1. Create two projects A and B
  2. B depends on A
  3. Create a transformer in project A
  4. Add it to B's pubspec.yaml
  5. 'pub serve' project B

What is the expected output? What do you see instead?

Expecting 'pub serve' not to crash. Instead, it crashes (stderr output from pub --trace 'serve' attached).

What version of the product are you using? On what operating system?

barback 0.11.1
Tried two Dart VM versions:
1.3.0-dev.0.0 (Wed Feb 26 07:39:42 2014) on "macos_x64"
1.2.0-dev.5.15 (Mon Feb 24 02:12:58 2014) on "macos_x64"

Attachment:
barback-sterr.log (146.37 KB)
@iposva-google
Copy link
Contributor

Added Pkg-Barback, Area-Pkg, Triaged labels.

@nex3
Copy link
Member

nex3 commented Mar 12, 2014

I can't reproduce this locally. Can you confirm this is still happening on the latest bleeding edge pub version, and if so can you provide a tarball of an app where this happens?

@nex3
Copy link
Member

nex3 commented Mar 14, 2014

Added CannotReproduce label.

@yjbanov
Copy link
Author

yjbanov commented Mar 14, 2014

So, it turns out I was incorrectly referring to the transformer. I needed to specify full path to the file where the transformer is defined, but instead I just used the package name. Bob N. says for that to work I have to name the file transformer.dart. I'll try that later.

However, that's not an excuse to produce illegible errors. It should clearly say "your transformer cannot be found" or sth like that, preferably w/o stack traces. So, I tried again. I cannot reproduce the exact same error, but I get a different error, this time even less legible that the last. Attaching both the stderr and the archived sample projects.

Dart VM version: 1.3.0-dev.3.2 (Mon Mar 10 11:06:13 2014) on "macos_x64"
Pub 1.3.0-dev.3.2

Attachments:
stderr.txt (929 Bytes)
sample-projects.zip (4.64 KB)

@nex3
Copy link
Member

nex3 commented Mar 14, 2014

It would be nice to improve these error messages, but currently the IsolateSpawnException API doesn't expose any information we can use to do so. I've filed issue #17492 to track that.

Removed Pkg-Barback, Area-Pkg labels.
Added Area-Pub, Triaged labels.
Marked this as being blocked by #17492.
Changed the title to: "Improve error messages when transformer plugins fail to load".

@nex3
Copy link
Member

nex3 commented Mar 25, 2014

Oops, I mean issue #17501.

Marked this as being blocked by #17501.
Unmarked this as being blocked by #17492.

@munificent
Copy link
Member

Issue #15594 has been merged into this issue.

@nex3
Copy link
Member

nex3 commented Jul 11, 2014

Issue #19961 has been merged into this issue.

This was referenced Jun 5, 2015
Closed
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#896.

@DartBot DartBot closed this as completed Jun 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nex3 @kevmoo @munificent @yjbanov @iposva-google @DartBot