https://codereview.chromium.org/240003005/

r35132

Added Fixed label.

Rolled back as https://codereview.chromium.org/252703004/

Added Triaged label.

Set owner to @danrubel.
Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

Another manifestation of this bug is that it causes confusing warnings of the form "Foo cannot be assigned to Foo". Here's a repro:

• Create a new project. In its pubspec.yaml, add a dependency on package "analyzer" version 0.15.1 (any package will do--I'm just using this as an example).
• Add a file file1.dart:

  import 'package:analyzer/analyzer.dart';
  import 'file2.dart';
  main() {
    AstNode node = null;
    foo(node);
  }

• Add a file file2.dart:

  import 'package:analyzer/analyzer.dart';
  foo(AstNode node) {
  }

• There should be no warnings.
• Change pubspec.yaml to reference analyzer version 0.15.3 instead of version 0.15.1. Still no warnings.
• Make a trivial edit to file1.dart (e.g. add a blank line). Suddenly a warning appears: "The argument type 'AstNode (.../.pub-cache/hosted/pub.dartlang.org/analyzer-0.15.3/lib/src/generated/ast.dart)' cannot be assigned to the parameter type 'AstNode (.../.pub-cache/hosted/pub.dartlang.org/analyzer-0.15.1/lib/src/generated/ast.dart)'".

A similar effect can happen even without changing the pubspec, if the version of analyzer is upgraded on the server and the user reruns "pub get".

The reason this happens is that after changing pubspec.yaml, the analyzer fails to notice that file1.dart and file2.dart are now referring to different versions of analyzer.dart than they were previously (and hence need to be reanalyzed). After file1.dart is trivially edited, the analyzer reanalyzes it and discovers that it is now referring to the AstNode from analyzer version 0.15.3. But it still (incorrectly) thinks file2.dart is still using the AstNode from analyzer version 0.15.1, so it reports the bogus warning.

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

We decided this morning not to bother fixing this in the Java-based analyzer, since we are in the process of replacing that with he Dart-based analysis server.

I'm working on the fix for the Dart-based analysis server.

Set owner to @stereotype441.
Added Started label.

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

Removed Oldschool-Milestone-1.6 label.

Removed Area-Editor label.
Added Area-Analyzer label.

Added Analyzer-Server label.

Cannot reproduce; assumed stale.