Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP package: need a way to accept bad certificates #17173

Closed
DartBot opened this issue Feb 27, 2014 · 5 comments
Closed

HTTP package: need a way to accept bad certificates #17173

DartBot opened this issue Feb 27, 2014 · 5 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@DartBot
Copy link

DartBot commented Feb 27, 2014

This issue was originally filed by kaisellgren@gmail.com


I'm trying to read URIs such as http://devblog.paypal.com/feed/ that lead to a bad certificate exception.

Can we add a callback to handle bad certificates in the HTTP package? For .get, .read, etc.?

Simplest reproduce step is: http.read('http://devblog.paypal.com/feed/');

@lrhn
Copy link
Member

lrhn commented Feb 27, 2014

Added Pkg-Http, Area-Pkg, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Sep 6, 2014

This comment was originally written by f41ltastic...@gmail.com


If this was triaged, I don't see where.

@sgjesse
Copy link
Contributor

sgjesse commented Sep 8, 2014

In dart.io the HttpClient have a callback to handle bad certificates, e.g.

import 'dart:io';
import 'dart:convert';

void main(List<String> args) {
  var client = new HttpClient();
  client.badCertificateCallback = (_, __, ___) => true;
  client.getUrl(Uri.parse("http://devblog.paypal.com/feed/"))
      .then((req) => req.close())
      .then((resp) => resp.transform(UTF8.decoder).join(''))
      .then(print)
      .whenComplete(() => client.close());
}

@sgjesse
Copy link
Contributor

sgjesse commented Sep 8, 2014

Issue #20832 has been merged into this issue.

@DartBot DartBot added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Sep 8, 2014
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/http#14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Development

No branches or pull requests

4 participants