Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use canonical fields for closure function and context #17160

Closed
iposva-google opened this issue Feb 27, 2014 · 1 comment
Closed

Use canonical fields for closure function and context #17160

iposva-google opened this issue Feb 27, 2014 · 1 comment
Labels
area-vm type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@iposva-google
Copy link
Contributor

Context of the discussion:
https://codereview.chromium.org/178233003/diff/70001/runtime/vm/flow_graph_builder.cc#newcode2287

We should allocate the fields for the closure function and context once at VM or isolate startup. They should be part of the _FunctionImpl class.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@rmacnak-google
Copy link
Contributor

Stale. All closures are now instances of a single class, instead of the old class per signature per library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants