Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pub transformers running on own package get modified package: URIs #17156

Closed
blois opened this issue Feb 26, 2014 · 4 comments
Closed

Pub transformers running on own package get modified package: URIs #17156

blois opened this issue Feb 26, 2014 · 4 comments
Assignees

Comments

@blois
Copy link
Contributor

blois commented Feb 26, 2014

When a pub transformer is running on it's own package the Dart source files that it loads have package: imports changed to /package/.

The conversion from package: to /package/ should be an internal detail- if required for isolate loading then assets fetched via transform.readAsInputString should use a different transfer mechanism.

These imports leak when the transformer modifies the source code- if the transformer does not remove the /package/ then this propagates down the chain.

@nex3
Copy link
Member

nex3 commented Feb 27, 2014

We could probably make [transform.readAsInputString] avoid this, but it would likely be a lot of work and further degrade the "pub serve"/"pub build" startup time. The "/package/" workaround will go away when issue #12474 is fixed, so I'm going to mark this blocked.


Marked this as being blocked by #12474.

@kevmoo
Copy link
Member

kevmoo commented Mar 26, 2015

Can this be addressed now?


Set owner to @nex3.

@nex3
Copy link
Member

nex3 commented Mar 26, 2015

I believe this is no longer an issue.


Added Fixed label.

@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/pub#890.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants