Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ship dartium with symbols on our release channels #17105

Closed
ricowind opened this issue Feb 25, 2014 · 1 comment
Closed

Don't ship dartium with symbols on our release channels #17105

ricowind opened this issue Feb 25, 2014 · 1 comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@ricowind
Copy link
Contributor

The current version of dartium that we ship has a ton of symbols in them. We should utilize the gyp variables that enables us to get the symbols stripped (and dumped to a file) from the dartium target for all release builds that we ship on dev and stable. That way we still have the symbols available if we get a dump and without having ton of symbols shipped to users (I see a 70 meg reduction on the mac dartium size, 30 on linux if I just strip them using strip).

Questions:
Is there some (good) reason why we have not already done this?
Do we want to keep the symbols on the bleeding edge builders (I say we do, the stacks we get there are good indication when something goes wrong)

Vijay: I am tentatively assigning this to you, but feel free to pass this along or reasign back to me

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Mar 1, 2016
@vsmenon vsmenon removed their assignment Jun 30, 2017
@athomas
Copy link
Member

athomas commented Nov 15, 2017

Not shipping dartium anymore.

@athomas athomas closed this as completed Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

4 participants