Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entries for http_parser and http_impl do not show up as being in dart:io in stack traces #17083

Closed
kevmoo opened this issue Feb 24, 2014 · 4 comments
Assignees
Labels

Comments

@kevmoo
Copy link
Member

kevmoo commented Feb 24, 2014

  1. Run this dart code to create a server

import 'dart:io';

void main() {
  HttpServer.bind('localhost', 8181).then((server) {
    server.listen((request) {
      throw 'foo!';
    });
  });
}

  1. Connect to localhost:8181 with a browser

  2. Look at the stack trace (see bottom)

Lines #­9, #­10 refer to http_impl
Lines #­19, #­20 refer to http_parser

No dart:* library is part of the path. Should be dart:io.

­0 main.<anonymous closure>.<anonymous closure> (file:///Users/kevmoo/source/github/shelf.dart/test/foo.dart:11:7)

­1 _rootRunUnary (dart:async/zone.dart:717)

­2 _RootZone.runUnary (dart:async/zone.dart:854)

­3 _BaseZone.runUnaryGuarded (dart:async/zone.dart:569)

­4 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:333)

­5 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263)

­6 _StreamController&&_SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:529)

­7 _StreamController._add (dart:async/stream_controller.dart:438)

­8 _StreamController.add (dart:async/stream_controller.dart:395)

­9 _HttpServer._handleRequest (http_impl.dart:2116)

­10 _HttpConnection._HttpConnection.<anonymous closure> (http_impl.dart:1954)

­11 _rootRunUnary (dart:async/zone.dart:717)

­12 _RootZone.runUnary (dart:async/zone.dart:854)

­13 _BaseZone.runUnaryGuarded (dart:async/zone.dart:569)

­14 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:333)

­15 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263)

­16 _StreamController&&_SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:529)

­17 _StreamController._add (dart:async/stream_controller.dart:438)

­18 _StreamController.add (dart:async/stream_controller.dart:395)

­19 _HttpParser._doParse (http_parser.dart:687)

­20 _HttpParser._parse (http_parser.dart:343)

­21 _onData (http_parser.dart:813)

­22 _rootRunUnary (dart:async/zone.dart:717)

­23 _RootZone.runUnary (dart:async/zone.dart:854)

­24 _BaseZone.runUnaryGuarded (dart:async/zone.dart:569)

­25 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:333)

­26 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263)

­27 _StreamController&&_SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:529)

­28 _StreamController._add (dart:async/stream_controller.dart:438)

­29 _StreamController.add (dart:async/stream_controller.dart:395)

­30 _onData (dart:io-patch/socket_patch.dart:1356)

­31 _rootRunUnary (dart:async/zone.dart:717)

­32 _RootZone.runUnary (dart:async/zone.dart:854)

­33 _BaseZone.runUnaryGuarded (dart:async/zone.dart:569)

­34 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:333)

­35 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263)

­36 _StreamController&&_SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:529)

­37 _StreamController._add (dart:async/stream_controller.dart:438)

­38 _StreamController.add (dart:async/stream_controller.dart:395)

­39 _RawSocket._RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:948)

­40 multiplex (dart:io-patch/socket_patch.dart:604)

­41 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:115)

@nex3
Copy link
Member

nex3 commented Feb 25, 2014

See also issue #11901.

@iposva-google
Copy link
Contributor

Removed Area-VM label.
Added Area-IO label.

@iposva-google
Copy link
Contributor

Issue #11901 has been merged into this issue.

@andersjohnsen
Copy link

Fix landed in r33799.


Set owner to @skabet.
Removed Area-IO label.
Added Area-VM, Fixed labels.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants