Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docgen/test/multi_library_test is slow #17060

Closed
floitschG opened this issue Feb 24, 2014 · 8 comments
Closed

docgen/test/multi_library_test is slow #17060

floitschG opened this issue Feb 24, 2014 · 8 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@floitschG
Copy link
Contributor

I just needed to mark docgen/test/multi_library_test as slow.

@efortuna
Copy link
Contributor

cc'ing Kevin, who has been adding to these tests recently. Otherwise, this may be a mirrors issue.

Is our test running docgen with --include-sdk? If not, it shouldn't be slow.


cc @kevmoo.

@alan-knight
Copy link
Contributor

What's the threshold for slow? Running the tests locally that test seems to be on the order of 3 seconds.

@floitschG
Copy link
Contributor Author

I can't find the failing column anymore.
Could be, that it was only slow on checked mode (where it currently takes more than a minute).

@alan-knight
Copy link
Contributor

Where does it take more than a minute? Locally, even in checked debug mode it's only about 15 seconds. It's 30 seconds to run all of the pkg/docgen tests.

@floitschG
Copy link
Contributor Author

@alan-knight
Copy link
Contributor

Ah, in dart2js as well. That's still only 35 seconds on my machine but that's at least plausible it could be slower on a bot. So that will have the compile overhead. Also, I notice that seven of the other tests in that slow list are for mirrors, and none of them are in the corresponding list for the VM. The test itself is 7x slower on dartj2s than on the Linux VM checked mode. So at a first guess dart2js mirrors are a candidate for being the issue.

I'm not sure what to do with this. I'll push it over to dartj2s mirrors and see if there are any thoughts.


Removed Area-DartDoc label.
Added Area-Dart2JS, Library-Mirrors labels.

@johnniwinther
Copy link
Member

docgen/test/typedef_test is also slow. Probably for the same or similar reasons.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Mar 3, 2018
@matanlurey
Copy link
Contributor

Mirrors is no longer supported in Dart2JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

6 participants