New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docgen/test/multi_library_test is slow #17060
Comments
cc'ing Kevin, who has been adding to these tests recently. Otherwise, this may be a mirrors issue. Is our test running docgen with --include-sdk? If not, it shouldn't be slow. cc @kevmoo. |
What's the threshold for slow? Running the tests locally that test seems to be on the order of 3 seconds. |
I can't find the failing column anymore. |
Where does it take more than a minute? Locally, even in checked debug mode it's only about 15 seconds. It's 30 seconds to run all of the pkg/docgen tests. |
Scroll down to see the 20 slowest tests. |
Ah, in dart2js as well. That's still only 35 seconds on my machine but that's at least plausible it could be slower on a bot. So that will have the compile overhead. Also, I notice that seven of the other tests in that slow list are for mirrors, and none of them are in the corresponding list for the VM. The test itself is 7x slower on dartj2s than on the Linux VM checked mode. So at a first guess dart2js mirrors are a candidate for being the issue. I'm not sure what to do with this. I'll push it over to dartj2s mirrors and see if there are any thoughts. Removed Area-DartDoc label. |
docgen/test/typedef_test is also slow. Probably for the same or similar reasons. |
Mirrors is no longer supported in Dart2JS. |
I just needed to mark docgen/test/multi_library_test as slow.
The text was updated successfully, but these errors were encountered: