Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update silently fails to update the dart executable if it's currently in use #17018

Closed
DartBot opened this issue Feb 21, 2014 · 14 comments
Closed

update silently fails to update the dart executable if it's currently in use #17018

DartBot opened this issue Feb 21, 2014 · 14 comments
Assignees
@danrubel
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
1.7

Comments

@DartBot
Copy link

DartBot commented Feb 21, 2014

This issue was originally filed by googlegroups...@kaioa.com

I forgot that I had a Dart command line application running when I used the editor's update function. It updated everything except for the Dart executable.

I wasn't notified about this issue. I only noticed that something went wrong, because dartfmt failed spectacularly with the old executable.

When I checked the bin directory, I could clearly see that the executable was older than everything else.

According to Dart Editor, it was up to date. I had to fix the issue manually by downloading the SDK and extracting its dart executable into my bin directory.
@sethladd
Copy link
Contributor

Added Area-Editor, Triaged labels.

@clayberg
Copy link

Set owner to @pq.
Added this to the 1.3 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@clayberg
Copy link

clayberg commented Apr 9, 2014

Removed this from the 1.3 milestone.
Added this to the 1.4 milestone.

@kasperl
Copy link

kasperl commented May 8, 2014

Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@sethladd
Copy link
Contributor

Hi Phil.

Looks related to a previous issue. We should do what we can do keep our users properly updated. Thanks for taking a look!

Added this to the 1.7 milestone.
Removed Priority-Medium label.
Added Priority-High label.

@sethladd
Copy link
Contributor

Added Editor-Updater label.

@danrubel
Copy link

Set owner to @danrubel.
Added Started label.

@danrubel
Copy link

https://codereview.chromium.org/561293004/

@danrubel
Copy link

!ENTRY org.eclipse.ui 4 0 2014-09-22 20:43:45.509
!MESSAGE Unhandled event loop exception
!STACK 0
java.lang.NullPointerException
    at com.google.dart.tools.update.core.internal.jobs.InstallUpdateAction$Executable.<init>(InstallUpdateAction.java:68)
    at com.google.dart.tools.update.core.internal.jobs.InstallUpdateAction.run(InstallUpdateAction.java:191)
    at com.google.dart.tools.update.core.UpdateManager.scheduleInstall(UpdateManager.java:164)
    at com.google.dart.tools.ui.dialogs.UpdateStatusControl$1.run(UpdateStatusControl.java:74)
    at com.google.dart.tools.ui.dialogs.UpdateStatusControl$UpdateAction.runWithSelectionEvent(UpdateStatusControl.java:56)
    at com.google.dart.tools.ui.dialogs.UpdateStatusControl.performAction(UpdateStatusControl.java:330)
    at com.google.dart.tools.ui.dialogs.UpdateStatusControl.access$12(UpdateStatusControl.java:328)
    at com.google.dart.tools.ui.dialogs.UpdateStatusControl$13.widgetSelected(UpdateStatusControl.java:315)
    at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
    at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4169)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3758)
    at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
    at org.eclipse.jface.window.Window.open(Window.java:801)
    at org.eclipse.ui.internal.dialogs.WorkbenchPreferenceDialog.open(WorkbenchPreferenceDialog.java:215)
    at com.google.dart.tools.ui.update.SettingsControlContribution$1.run(SettingsControlContribution.java:170)
    at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
    at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
    at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4144)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3761)
    at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
    at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
    at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
    at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
    at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
    at com.google.dart.tools.deploy.DartIDEApplication.start(DartIDEApplication.java:85)
    at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629)
    at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584)
    at org.eclipse.equinox.launcher.Main.run(Main.java:1438)
    at org.eclipse.equinox.launcher.Main.main(Main.java:1414)

@danrubel
Copy link

https://codereview.chromium.org/596793002/

Added Fixed label.

@clayberg
Copy link

Issue #20794 has been merged into this issue.

cc @danrubel.

@DartBot DartBot added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Oct 20, 2014
@DartBot DartBot added this to the 1.7 milestone Oct 20, 2014
@clayberg clayberg mentioned this issue Jun 4, 2015
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danrubel danrubel

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
1.7
Development

No branches or pull requests
5 participants
@sethladd @kasperl @danrubel @clayberg @DartBot