Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: get rid of build.dart #17013

Closed
kasperl opened this issue Feb 21, 2014 · 6 comments
Closed

samples: get rid of build.dart #17013

kasperl opened this issue Feb 21, 2014 · 6 comments
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used. closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@kasperl
Copy link

kasperl commented Feb 21, 2014

Do we still need build.dart in the samples or has it been replaced by 'pub build' completely?

It is still used from the todomvc sample we ship with the editor.
@jmesserly
Copy link

AFAIK, it can't be done until the editor has a replacement for Polymer's HTML analysis, or an alternate way for a package to provide this functionality. We have a lot of very useful warnings/errors that would disappear if we removed build.dart

@jmesserly
Copy link

Marked this as being blocked by #15146.

@jmesserly
Copy link

@bob, will there be a general way for Pub transformers to participate in Editor analysis?

@keertip
Copy link
Contributor

keertip commented Feb 21, 2014

cc @scheglov.

@sigmundch
Copy link
Member

to clarify - the pub-build also prints these warnings. So while they wouldn't entirely disappear, they would not be integrated with the editor (which I think is a great usability piece for users)

@jmesserly
Copy link

yeah, I think in practice no one would see them anymore though :)

@kasperl kasperl added Type-Defect area-samples (deprecated) Deprecated: this label is no longer actively used. labels Feb 21, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-samples (deprecated) Deprecated: this label is no longer actively used. closed-obsolete Closed as the reported issue is no longer relevant type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @matanlurey @jmesserly @sigmundch @kasperl @keertip