Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate then remove *Changed listeners #16993

Closed
jmesserly opened this issue Feb 20, 2014 · 14 comments
Closed

deprecate then remove *Changed listeners #16993

jmesserly opened this issue Feb 20, 2014 · 14 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@jmesserly
Copy link

"Changed" is a magic method suffix:
http://www.polymer-project.org/docs/polymer/polymer.html#change-watchers

it's happened quite a few times that people get errors because of this feature... they expect to use *Changed as an event listener and not have it be magic.

I think we should remove this feature from the Dart port, as it is largely replaced by another feature that is more explicit and IMHO more obvious (@­ObserveProperty -- currently in our under development 0.10.0-dev pkg, inspired by this polymer.js feature: http://www.polymer-project.org/docs/polymer/polymer.html#observeblock), and fits the polymer.dart pattern of using metadata for things recognized by the base class.
@jmesserly
Copy link
Author

Removed Type-Defect label.
Added Type-Enhancement label.

@sigmundch
Copy link
Member

also - if for some reason we want to keep the feature (compat with polymer.js), then we could be more careful about fooChanged and only doing something special if there is a correspoing observable property named foo.

I also lean towards removing the feature.

@ussuri
Copy link

ussuri commented Feb 20, 2014

As a user of the feature, I can attest that it's always seemed "too magical" to me. It's seemed to be in a stark contrast with the explicitness of, say, @­CustomTag('my-element') class MyElement. So yes, making it more explicit would be more user-friendly and less error-prone.

@jmesserly
Copy link
Author

Removed Area-Polymer label.
Added area-pkg, Pkg-Polymer labels.

@jmesserly
Copy link
Author

Removed Library-Polymer label.

@sigmundch
Copy link
Member

Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@sigmundch
Copy link
Member

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Next label.

@jmesserly jmesserly added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Jul 9, 2014
@jmesserly
Copy link
Author

@jakemac53 is this fixed in new polymer?

@jakemac53
Copy link
Contributor

Yes in the new polymer these methods will no longer exist

@jakemac53
Copy link
Contributor

Closing this because I will forget later

@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#120.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @jakemac53 @jmesserly @sigmundch @ussuri @DartBot