Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method html:Window.find is poorly documented #16930

Open
DartBot opened this issue Feb 19, 2014 · 6 comments
Open

method html:Window.find is poorly documented #16930

DartBot opened this issue Feb 19, 2014 · 6 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html P3 A lower priority bug or feature request type-documentation A request to add or improve documentation web-libraries Issues impacting dart:html, etc., libraries

Comments

@DartBot
Copy link

DartBot commented Feb 19, 2014

This issue was originally filed by alexe.kaigorodov@gmail.com


What is the sense of parameter "backwards"? Its existence make me think that the searching starts from some point inside the window, not always from the very beginning. If it is so, it should be clearly stated.

The following code

  var text = 'text';
  document.body.append(new Text(text));
  bool res1=window.find(text, false, false, false, false, false, false);
  bool res2=window.find(text, false, false, false, false, false, false);
  print("res1=$res1 res2=$res2");

prints "res1=true res2=false"

which supports this hypothesis. If so, then if we change second search with backward search:

  bool res2=window.find(text, false, false, false, false, false, false);

res2 should be true, but its is not.

@DartBot
Copy link
Author

DartBot commented Feb 19, 2014

This comment was originally written by alexe.kaigorodov@gmail.com


Correction: should read:

which can be explained with hypothesis that the search point is where the previous search ended. If so, then if we change second search with backward search:

  bool res2=window.find(text, false, true, false, false, false, false);

res2 should be true, but it is still false.

@lrhn
Copy link
Member

lrhn commented Feb 19, 2014

Added Area-HTML, Triaged labels.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@alan-knight
Copy link
Contributor

Documentation issue. I note that the doc points to the MDN docs for the function, which seems to be identical, and which there's a pending issue to remove it, since it's non-portable, hard to use, and buggy.


Removed Type-Defect label.
Added Type-Documentation label.

@DartBot DartBot added type-documentation A request to add or improve documentation Priority-Unassigned area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Jan 16, 2015
@srawlins
Copy link
Member

@srawlins srawlins added the P3 A lower priority bug or feature request label Jun 29, 2018
@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
@sgrekhov
Copy link
Contributor

sgrekhov commented Sep 8, 2020

Still an issue

@sigmundch sigmundch added the web-libraries Issues impacting dart:html, etc., libraries label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html P3 A lower priority bug or feature request type-documentation A request to add or improve documentation web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

8 participants