Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualDirectory.serveFile should return a Future #16924

Closed
DartBot opened this issue Feb 19, 2014 · 2 comments
Closed

VirtualDirectory.serveFile should return a Future #16924

DartBot opened this issue Feb 19, 2014 · 2 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Feb 19, 2014

This issue was originally filed by diego.rocha.c...@gmail.com

VirtualDirectory.serveFile of http_server library should return a Future that completes when the file has been successfully served.

It is a small change, so I made a CL: https://codereview.chromium.org/171363006
@kevmoo
Copy link
Member

kevmoo commented Feb 19, 2014

cc @skabet.
Removed Type-Defect label.
Added Type-Enhancement, Pkg-HttpServer, Area-Pkg, Triaged labels.

@DartBot DartBot added Type-Enhancement area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Feb 19, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Open
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/http_server#24.

@DartBot DartBot closed this as completed Jun 5, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevmoo @DartBot