Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart2Js generates two function that are the same, how about only generating one #16866

Open
DartBot opened this issue Feb 16, 2014 · 3 comments
Open

Dart2Js generates two function that are the same, how about only generating one #16866

DartBot opened this issue Feb 16, 2014 · 3 comments
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. dart2js-optimization type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@DartBot
Copy link

DartBot commented Feb 16, 2014

This issue was originally filed by LukeEChurc...@gmail.com

Dart2Js generates two function that are the same, how about only generating one of them if they are the same?

TI:function(a,b,c,d){if(this.L2<this.GV)throw H.b(new P.AT("Stride cannot be smaller than the vector size."))},
qR:function(a,b,c,d){if(this.L2<this.GV)throw H.b(new P.AT("Stride cannot be smaller than the vector size."))}
@DartBot
Copy link
Author

DartBot commented Feb 16, 2014

This comment was originally written by LukeEChu...@gmail.com

(Sorry, should have noted, this is reported in Editor feedback, no further detail given)

@floitschG
Copy link
Contributor

Added Optimization label.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@rakudrama
Copy link
Member

They are the same, but the stack trace will be different.
We should probably only share functions if we can undo the shared stack frames.

@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. dart2js-optimization type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @rakudrama @vsmenon @floitschG @DartBot