Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devtools doesn't report stack trace information for console log #16805

Closed
devoncarew opened this issue Feb 13, 2014 · 2 comments
Closed

devtools doesn't report stack trace information for console log #16805

devoncarew opened this issue Feb 13, 2014 · 2 comments
Assignees
@jacob314
Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@devoncarew
Copy link
Member

Possibly a Dartium 33 regression? We don't get stack traces with the 'Console.messageAdded' events. Or we do, but they don't have valid information. The url and functionName fields are 'undefined'.

"stackTrace":[{"lineNumber":0,"scriptId":"","functionName":"undefined","columnNumber":0,"url":"undefined"}]

We had been seeing correct information in earlier builds (definitely in Dartium 31; not sure about 32).
@jacob314
Copy link
Member

I believe this got broken in the Chrome 32 merge.
asiva recently tweaked the code so at least we get a significant performance win by not showing the source location. Previously you could only send ~1000 console messages a second.

cc @a-siva.
cc @vsmenon.

@devoncarew
Copy link
Member Author

OK, I verified that we see the same thing in the devtools console.

For the editor, the most valuable information is the top frame - the location where the print() call occurred. If we can get most of the performance benefit by only reporting the top frame in the stack trace, that would be great. I.e., not reporting the other n-1 frames.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacob314 jacob314

Labels
type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @matanlurey @jacob314 @devoncarew