Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long constructor formatted incorrectly #16794

Closed
stevemessick opened this issue Feb 13, 2014 · 9 comments
Closed

Long constructor formatted incorrectly #16794

stevemessick opened this issue Feb 13, 2014 · 9 comments
Assignees
@pq
Labels
closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug

Comments

@stevemessick
Copy link
Contributor

Formatter, I don't see why this change is a good idea. Parentheses?should be alone in a line or should they?

      throw new
          StateError('Setting the id of an entity is not allowed after the entity was added to an entity manager!');

was changed to:

      throw new StateError(
          'Setting the id of an entity is not allowed after the entity was added to an entity manager!'
          );

////////////////////////////////////////////////////////////////////////////////////
Editor: 1.2.0.dev_04_00 (2014-02-07)
OS: Windows 8 - amd64 (6.2)
JVM: 1.7.0_45

projects: 1

open dart files: 0

auto-run pub: true
localhost resolves to: 127.0.0.1
mem max/total/free: 1778 / 440 / 256 MB
thread count: 30
index: 39700 relationships in 9578 keys in 86 sources

SDK installed: true
Dartium installed: true
@clayberg
Copy link

Removed Type-Defect label.
Added Type-Enhancement label.

@pq
Copy link
Member

pq commented Apr 9, 2014

Removed this from the 1.3 milestone.
Added this to the 1.4 milestone.

@kevmoo
Copy link
Member

kevmoo commented Apr 27, 2014

Marked this as blocking #16327.

@kasperl
Copy link

kasperl commented May 8, 2014

Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@munificent
Copy link
Member

Added AssumedStale label.

@stevemessick stevemessick added Type-Enhancement closed-obsolete Closed as the reported issue is no longer relevant labels Feb 13, 2015
This was referenced Jun 5, 2015
Closed
Closed
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/dart_style#314.

@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
closed-obsolete Closed as the reported issue is no longer relevant type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@kevmoo @munificent @pq @kasperl @stevemessick @clayberg @DartBot