Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docgen inherited variables don't get inheritedFrom set #16783

Closed
alan-knight opened this issue Feb 13, 2014 · 7 comments
Closed

Docgen inherited variables don't get inheritedFrom set #16783

alan-knight opened this issue Feb 13, 2014 · 7 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-obsolete Closed as the reported issue is no longer relevant

Comments

@alan-knight
Copy link
Contributor

Consider
/// This is a comment for the library.
library hello;

class T1 {
  bool foo = true;
  bool bar() => true;
}

class T2 extends T1 {
}

main() {
  print(new T2.blah(true));
}

which produces JSON with the qualified name set on foo but not the inheritedFrom. For the bar method it does set the inheritedFrom field.

  "inheritedVariables": {
    "foo": {
      "name": "foo",
      "qualifiedName": "hello.T1.foo",
      "comment": "",
      "final": "false",
      "static": "false",
      "constant": "false",
      "type": [
        {
          "outer": "dart-core.bool",
          "inner": [
            
          ]
        }
      ],
      "annotations": [
        
      ]
    }
  },

@kevmoo
Copy link
Member

kevmoo commented Mar 17, 2014

Added Pkg-DartDoc label.

@kevmoo
Copy link
Member

kevmoo commented Mar 17, 2014

Removed Area-DartDoc label.
Added Area-Pkg label.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Pkg-DartDoc label.
Added Pkg-DocGen label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Added this to the 1.6 milestone.

@sethladd
Copy link
Contributor

Marked as High, assigning owner. If I get this wrong, please help me by:

* assigning a new owner

  • changing priority
  • changing milestone

Set owner to @alan-knight.

@alan-knight
Copy link
Contributor Author

Removed the owner.
Removed this from the 1.6 milestone.
Removed Priority-High label.
Added Priority-Medium label.

@sethladd
Copy link
Contributor

Added AssumedStale label.

@alan-knight alan-knight added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-obsolete Closed as the reported issue is no longer relevant labels Jan 12, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

4 participants