Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream tests fails in checked mode after roll to chrome 33 #16719

Closed
ricowind opened this issue Feb 11, 2014 · 7 comments
Closed

stream tests fails in checked mode after roll to chrome 33 #16719

ricowind opened this issue Feb 11, 2014 · 7 comments
Assignees
@lrhn
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-async

Comments

@ricowind
Copy link
Contributor

lib/async/test/stream_zip_test
pkg/async/test/stream_zip_test

See e.g.
http://build.chromium.org/p/client.dart/builders/dart2js-drt-linux-2-2-be/builds/1378/steps/dart2js-drt%20tests%20--checked%20failures/logs/stdio

Fails with:
CONSOLE MESSAGE: line 78: {
  "type": "print",
  "value": "ERROR: Error after first end\n Test failed: Caught NoSuchMethodError: Cannot call "apply" on "#<Object>" (Object #<Object> has no method 'apply')\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 2377:68 null.$signature\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 3376:56 RuntimeFunctionType._extractFunctionTypeObjectFrom$1\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 3346:37 RuntimeFunctionType._isTest$1\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 3365:16 RuntimeFunctionType._check$2\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 3355:19 RuntimeFunctionType._assertCheck$1\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 6644:52 _ControllerStream._StreamImpl.listen$4$cancelOnError$onDone$onError\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 6653:19 _ControllerStream._StreamImpl.listen$3$onDone$onError\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 7314:37 _SinkTransformerStreamSubscription._SinkTransformerStreamSubscription$3\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 7373:20 _BoundSinkStream.listen$4$cancelOnError$onDone$onError\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 11580:43 StreamZip.listen$4$cancelOnError$onDone$onError\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 11607:19 StreamZip.listen$2$onDone\n ../../../generated_compilations/dart2js-checked/pkg_async_test_stream_zip_test/test.js 12606:75 main_testZip.call$2",
  "timestamp": 0.896

Reproducable locally by running:
tools/test.py -mrelease -cdart2js -rdrt --checked pkg/async/test/stream_zip_test
@ricowind
Copy link
Contributor Author

lib/async/test/stream_zip_test may be related to https://code.google.com/p/v8/issues/detail?id=3084 (and so could the other one, but we should validate)

@lrhn
Copy link
Member

lrhn commented Feb 11, 2014

Added Area-Library label.

@kasperl
Copy link

kasperl commented Feb 12, 2014

The tests pass in CSP mode.

@ricowind
Copy link
Contributor Author

This started passing here:
http://build.chromium.org/p/client.dart/builders/dart2js-drt-linux-2-2-be/builds/1597

@ricowind
Copy link
Contributor Author

I removed the suppression for pkg/async/test/stream_zip_test

The only remaining suppression with this issue number is for
lib/async/stream_transform_test
I assume that could be unrelated, maybe retriage that?

@karlklose
Copy link
Contributor

pkg/async/test/stream_zip_test started passing again, but I don't know after which revision.

@lrhn
Copy link
Member

lrhn commented Apr 20, 2015

Added AssumedStale label.

@ricowind ricowind added Type-Defect library-async area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant labels Apr 20, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-async
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @kasperl @lrhn @ricowind @karlklose