Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for websocket continuation frames #16569

Open
DartBot opened this issue Feb 6, 2014 · 7 comments
Open

Add support for websocket continuation frames #16569

DartBot opened this issue Feb 6, 2014 · 7 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug web-libraries Issues impacting dart:html, etc., libraries

Comments

@DartBot
Copy link

DartBot commented Feb 6, 2014

This issue was originally filed by @epelc

What steps will reproduce the problem?
1.Send a continuation frame(opcode 0) to a websocket client

What is the expected output? What do you see instead?
There should be support for continuation frames, instead there is nothing.

What version of the product are you using? On what operating system?
SDK v1.1.1 on mac os x 10.9

Please provide any additional information below.
Im using golang and the package from github.com/gorilla/websocket which has support for buffered writing and therefore uses continuation frames. However when using dart's html package for websocket support on the client there is no way to handle these.
@lrhn
Copy link
Member

lrhn commented Feb 6, 2014

Added Area-HTML, Triaged labels.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@efortuna
Copy link
Contributor

Websocket is unstable, so this change is not the highest priority, but we should look to add this.

Nice readable background on the continuation frame: http://buildnewgames.com/websockets/

Removed Priority-Unassigned label.
Added Priority-Low label.

@efortuna
Copy link
Contributor

Added this to the Later milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@alan-knight
Copy link
Contributor

Removed Type-Defect label.
Added Type-Enhancement label.

@DartBot DartBot added Type-Enhancement P3 A lower priority bug or feature request area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Jan 13, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
@sigmundch sigmundch added the web-libraries Issues impacting dart:html, etc., libraries label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@kevmoo @sigmundch @efortuna @vsmenon @kasperl @alan-knight @lrhn @DartBot