Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

polymer_expressions/test/globals_test fails on polyfilled template #16568

Closed
jmesserly opened this issue Feb 6, 2014 · 14 comments
Closed

polymer_expressions/test/globals_test fails on polyfilled template #16568

jmesserly opened this issue Feb 6, 2014 · 14 comments
Assignees
@justinfagnani
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.

Comments

@jmesserly
Copy link

after https://code.google.com/p/dart/source/detail?r=32342

the polymer_expressions/test/globals_test test started failing on Safari/IE. Usually that means it fails on polyfilled <template> (Chrome and Firefox have native <template>)

tentatively pkg:polymer_expressions, but could be a pkg:template_binding issue
@jmesserly
Copy link
Author

also bindings_test after I added a new test :|

@justinfagnani
Copy link
Contributor

I added new tests to syntax_test and an now seeing failures on Safari. Looks like a problem with mirrors.

@jmesserly
Copy link
Author

Removed Area-Polymer label.
Added Area-Pkg, Pkg-PolymerExpressions labels.

@jmesserly
Copy link
Author

Removed Library-PolymerExpressions label.

@justinfagnani
Copy link
Contributor

This fix for this is to call TemplateBindExtension.bootstrap() on template nodes dynamically inserted into the document in the test.

@justinfagnani
Copy link
Contributor

I have a fix for this in https://codereview.chromium.org/141703024/

cc @jmesserly.
Set owner to @justinfagnani.

@sigmundch
Copy link
Member

Was this fixed in #­6, can we close the bug?

Added this to the 1.6 milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@sigmundch
Copy link
Member

Removed this from the 1.6 milestone.
Added Polymer-P-1 label.

@sigmundch
Copy link
Member

Removed Polymer-P-1 label.
Added Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

Added PolymerMilestone-Next label.

@sigmundch
Copy link
Member

Removed Polymer-Milestone-Next label.

@sigmundch
Copy link
Member

ping - Justin, was this already fixed in #­6 above?

@jmesserly jmesserly added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Sep 9, 2014
@jmesserly
Copy link
Author

assumed stale

@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-archive/polymer-dart#490.

@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinfagnani justinfagnani

Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @justinfagnani @jmesserly @sigmundch @DartBot