js_helper declares a class that appears to be abstract, but then instantiates it #16566
Labels
area-web
Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop.
type-bug
Incorrect behavior (everything from a crash to more subtle misbehavior)
web-dart2js
Error caught by the dart analyzer:
ERROR|STATIC_WARNING|FUNCTION_WITHOUT_CALL|/Users/efortuna/dart-git2/dart/sdk/lib/_internal/lib/js_helper.dart|2127|7|14|Concrete classes that implement Function must implement the method call()
ERROR|STATIC_WARNING|FUNCTION_WITHOUT_CALL|/Users/efortuna/dart-git2/dart/sdk/lib/_internal/lib/js_helper.dart|2132|7|12|Concrete classes that implement Function must implement the method call()
Basically we have a class defined like so:
class TearOffClosure extends Closure {
}
that doesn't define call(). However, if you mark it as abstract, you find that there are other spots in the code where we are instantiating TearOffClosure objects (?). I'm not tremendously familiar with the JShelper code, so I'm hoping someone more familiar with that corner of the codebase can tell me what the best fix is. (sra?)
filing for now under dart2js, even though the problem is the intersetion of dart2js, dart:html, and the analyzer.
The text was updated successfully, but these errors were encountered: