Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM debugger fails to set a working breakpoint at initializer expression #16413

Closed
fsc8000 opened this issue Jan 30, 2014 · 6 comments
Closed
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@fsc8000
Copy link
Contributor

fsc8000 commented Jan 30, 2014

Setting a breakpoint at the initializer assignment of x does not work.


class MyClass {
  var x = foo(); // Set breakpoint here.
}

foo() {
  print("here");
}

main() {
  var a = new MyClass();
}

@iposva-google
Copy link
Contributor

Added Accepted label.

@DartBot
Copy link

DartBot commented Jan 30, 2014

This comment was originally written by @mhausner


The VM debugger sets the breakpoint in the implicit getter function get:x() rather than in the initializer expression foo().

This is not easy to fix. The call to foo() is actually part of the initializer list of the synthetic constructor C().

@DartBot
Copy link

DartBot commented Jan 30, 2014

This comment was originally written by @mhausner


To elaborate further: a breakpoint at this initializer expression would have to map to a breakpoint in each constructor of MyClass.

An fix with reasonable effort is to treat the line with the initializer as having no executable code. (The debugger will not break in the implicit getter function get:x() anyway).

@DartBot
Copy link

DartBot commented Jan 30, 2014

This comment was originally written by @mhausner


As of r32183, the debugger says it can't place a breakpoint at the line that contains the initializer.


Added WontFix label.

@fsc8000
Copy link
Contributor Author

fsc8000 commented Feb 12, 2014

Reopening since even though it may not be urgent, I think that (1) this is a valid feature request and (2) not being able to set a breakpoint there is an unnecessary restriction.


Removed Type-Defect, Priority-Unassigned labels.
Added Type-Enhancement, Priority-Low, Triaged labels.

@iposva-google
Copy link
Contributor

cc @mhausner.
Set owner to @fsc8000.
Added Accepted label.

@fsc8000 fsc8000 added Type-Enhancement P3 A lower priority bug or feature request area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Feb 19, 2014
@fsc8000 fsc8000 self-assigned this Feb 19, 2014
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed accepted labels Feb 29, 2016
@mhausner mhausner added the closed-not-planned Closed as we don't intend to take action on the reported issue label Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

5 participants