Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html] Incorrect Element.isContentEditable #16394

Open
DartBot opened this issue Jan 29, 2014 · 6 comments
Open

[html] Incorrect Element.isContentEditable #16394

DartBot opened this issue Jan 29, 2014 · 6 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries

Comments

@DartBot
Copy link

DartBot commented Jan 29, 2014

This issue was originally filed by Ilya.V...@gmail.com


co19/LibTest/html/Element/isContentEditable_
A01_t01
co19/LibTest/html/Element/isContentEditable_A02_t01

Getter returns false for explicitely set true value:

  x = new Element.html('<div contenteditable="true"></div>',
      treeSanitizer: new NullTreeSanitizer());
  Expect.isTrue(x.isContentEditable, 'explicit true');

Also true value is not properly inherited in a child:

  x = new Element.html('<div contenteditable="true"><span><pre></pre></span></div>',
      treeSanitizer: new NullTreeSanitizer());
  y = x.querySelector('pre');
  Expect.isTrue(x.isContentEditable, 'inherited true');

@lrhn
Copy link
Member

lrhn commented Jan 29, 2014

Added Area-HTML, Triaged labels.

@giovannicandido
Copy link

Separated tests for the problem: https://github.com/giovannicandido/darthtml-content-editable-test

@giovannicandido
Copy link

I don't know way, but my tests are passing in the code link above, but the not in dart-archive/angular.dart#436 .

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@alan-knight
Copy link
Contributor

I think this is a normal Chrome behaviour that the value isn't computed until the element actually exists. So the tests pass in the separated link because those tests actually add the element to the DOM. If I modify the co19 tests to add to the DOM, the test passes.


Set owner to @alan-knight.
Added Started label.

@DartBot DartBot added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Dec 29, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@sstrickl
Copy link
Contributor

This test is causing reds on the dart2js-strong-mac-x64-safari bot since build 3331, where it became non-flaky (it was failing flakily before that). I'm going to approve this failure for now, because there are other failures due to the new RegExp features (that aren't supported on Safari) and I want to approve those.

@vsmenon vsmenon added the area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. label Jul 20, 2019
@sigmundch sigmundch added the web-libraries Issues impacting dart:html, etc., libraries label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Development

No branches or pull requests

8 participants