Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test lib/async/stream_timeout_test is flaky on dart2js/windows. #16362

Open
lrhn opened this issue Jan 28, 2014 · 1 comment
Open

Test lib/async/stream_timeout_test is flaky on dart2js/windows. #16362

lrhn opened this issue Jan 28, 2014 · 1 comment
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@lrhn
Copy link
Member

lrhn commented Jan 28, 2014

Test fails occasionally with the report including:
        {
              type: message_received
              value: dart-main-done
              timestamp: 0.142
        },
        {
              type: print
              value: Uncaught Error: Timeout not prevented by events
              timestamp: 1.597
        },

That is, a ~1.5 second delay after which the timeout fires.
This should not happen - the expected behavior is to add error events on the stream controller every 5 ms, 200 times, and then close the controller. The timeout of 500 ms should not have time to happen, and if there is more than 250 ms delay between the controller getting the error and the timeout happening, the test is dropped and won't fail.

Check that the close event isn't dropped somehow.

@lrhn lrhn added Type-Defect library-async area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Jan 28, 2014
@lrhn lrhn self-assigned this Jan 28, 2014
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@lrhn lrhn removed the core-a label Aug 11, 2017
@lrhn
Copy link
Member Author

lrhn commented Nov 12, 2021

This test now has a timeout of 2 seconds, which is longer than the timer runs.
It's not actually checking that the events are preventing a timeout any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

2 participants