try-dart: positions for warnings are wrong #16142
Assignees
Labels
type-enhancement
A request for a change that isn't a bug
Comments
|
The problem is that I grab the enclosing DOM node which might be larger than the token. See addDiagnostic in editor.dart which has this TODO: // TODO(ahe): Don't highlight everything in the node. Find Added Accepted label. |
|
A related problem is that EOF errors can be hard to see. I need to find a better way to present diagnostics. Also, I've noticed issues when you have multiple diagnostics on the same line. cc @lukechurch. |
|
https://codereview.chromium.org/140933003/ fixes the immediate problem but not the general issue of small diagnostics. |
|
I've updated http://r31889.try-dart-lang.appspot.com/ with this fix. |
|
Removed Type-Defect label. |
kevmoo
added
type-enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
http://r31889.try-dart-lang.appspot.com/
Typing in this code:
// Go ahead and modify this example.
var greeting = "Hello, World!";
// Prints a greeting.
void main() {
// The [print] function displays a message in the "Console" box.
// Try modifying the greeting above and watch the "Console" box change.
String s = 42;
print(greeting);
}
leads to the correct warning (int is not assignable to String), but the red warning marker covers everything from String s and forward (including the next lines).
The text was updated successfully, but these errors were encountered: