Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ParameterMirror.isInitializingFormal to dart:mirrors #16094

Closed
DartBot opened this issue Jan 14, 2014 · 4 comments
Closed

Add ParameterMirror.isInitializingFormal to dart:mirrors #16094

DartBot opened this issue Jan 14, 2014 · 4 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@DartBot
Copy link

DartBot commented Jan 14, 2014

This issue was originally filed by @seaneagan

dart2js mirrors has ParameterMirror.isInitializingFormal:

https://github.com/dart-lang/bleeding_edge/blob/master/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart#L834

This should be in dart:mirrors as well. It is useful for finding fields related to constructor parameters.
@DartBot
Copy link
Author

DartBot commented Jan 14, 2014

This comment was originally written by @seaneagan

For context, here's my use case:

seaneagan/unscripted#41

@lrhn
Copy link
Member

lrhn commented Jan 15, 2014

Keep this as defect, not enhancement - there shouldn't be public methods in dart2js that aren't in dart:mirror, or vice versa.

Added Area-Library, Library-Mirrors, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Jan 15, 2014

This comment was originally written by @seaneagan

issue #15704 should also be a defect then, since it is a feature implemented by dart2js mirrors, but not by dart:mirrors

@DartBot DartBot added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-mirrors labels Jan 15, 2014
@seaneagan seaneagan mentioned this issue Aug 27, 2015
Closed
@llamadonica
Copy link

https://codereview.chromium.org/1311613005 fixes

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@a-siva a-siva added closed-as-intended Closed as the reported issue is expected behavior closed-not-planned Closed as we don't intend to take action on the reported issue and removed closed-as-intended Closed as the reported issue is expected behavior labels Aug 5, 2022
@a-siva a-siva closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @llamadonica @lrhn @a-siva @DartBot