Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart2js: Reflective constructor access should be consistent in declarations and newInstance #16074

Closed
gbracha opened this issue Jan 14, 2014 · 2 comments
Assignees
Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js

Comments

@gbracha
Copy link
Contributor

gbracha commented Jan 14, 2014

The simple name of a constructor should be the identifier without the class or the constant symbol for the empty string if it is a default constructor. Currently this is not the case with unfortunate consequences.

One cannot lookup a constructor and use its simple name to run it, because the "simple" name is actually qualified by the class name. This leads to the need to do string surgery to call the constructor.
The qualified name ends up being library.Class.Class.id which is very confusing.

Once the simple name behaves correctly, these problems should go away.

@gbracha
Copy link
Contributor Author

gbracha commented Jan 14, 2014

See issue #13248.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Mar 3, 2018
@matanlurey
Copy link
Contributor

Mirrors is no longer supported in Dart2JS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant library-mirrors type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) web-dart2js
Projects
None yet
Development

No branches or pull requests

4 participants