Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support operator call #1604

Closed
DartBot opened this issue Feb 9, 2012 · 14 comments
Closed

Support operator call #1604

DartBot opened this issue Feb 9, 2012 · 14 comments
Assignees
@crelier
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Milestone
M2

Comments

@DartBot
Copy link

DartBot commented Feb 9, 2012

This issue was originally filed by ms...@unipro.ru

Support operator call for custom classes since it is already described in the specification.
@anders-sandholm
Copy link
Contributor

Added Area-VM, Triaged labels.

@madsager
Copy link
Contributor

madsager commented Mar 7, 2012

Issue #1986 has been merged into this issue.

@sethladd
Copy link
Contributor

sethladd commented May 7, 2012

Marked this as blocking #2931.

@iposva-google
Copy link
Contributor

Added this to the M1 milestone.

@anders-sandholm
Copy link
Contributor

Marked this as being blocked by #2931.

@iposva-google
Copy link
Contributor

Removed this from the M1 milestone.
Added this to the M2 milestone.
Marked this as blocking #2931.
Unmarked this as blocking #2931.
Marked this as being blocked by #2931.
Unmarked this as being blocked by #2931.

@DartBot
Copy link
Author

DartBot commented Oct 11, 2012

This comment was originally written by antonm@google.com

Issue #5797 has been merged into this issue.

cc @floitschG.

@dgrove
Copy link
Contributor

dgrove commented Oct 12, 2012

Issue #5835 has been merged into this issue.

@crelier
Copy link
Contributor

crelier commented Dec 12, 2012

Set owner to @crelier.
Added Started label.
Unmarked this as being blocked by #2931.

@crelier
Copy link
Contributor

crelier commented Dec 12, 2012

Fixed at r16009.

Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Dec 24, 2012

This comment was originally written by alexe.kaigorodov@gmail.com

The co19 test 14_Types/5_Function_Types_A06_t01 still fails.

@crelier
Copy link
Contributor

crelier commented Dec 27, 2012

Thanks for triaging this test. There are 3 issues with it:

line 21: the call method is missing a body, making it abstract. Failing the test is therefore correct, since there is actually no call method.

line 37: wrong expectation. new J() is f.

line 41: wrong expectation. new K() is f.

Thanks,
Regis

@DartBot
Copy link
Author

DartBot commented Dec 28, 2012

This comment was originally written by alexe.kaigorodov@gmail.com

After fixing, the test still fails:
out/Debug_ia32/dart --ignore-unrecognized-flags --enable-type-checks /home/kaigorodov/dash/dash/co19/tests/co19/src/Language/14_Types/5_Function_Types_A06_t01.dart
Unhandled exception:
Expect.isTrue(false) fails.
#­0 Expect._fail (bootstrap:655:5)
#­1 Expect.isTrue (bootstrap:494:10)
#­2 main (file:///home/kaigorodov/dash/dash/co19/tests/co19/src/Language/14_Types/5_Function_Types_A06_t01.dart:33:16)

typedef void f(p1, p2);
class I {
  void call(a1, a2){}
}
Expect.isTrue(new I() is f); // line 33

@ghost
Copy link

ghost commented Dec 28, 2012

Should be fixed with r16541

@DartBot DartBot added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Dec 28, 2012
@DartBot DartBot added this to the M2 milestone Dec 28, 2012
@DartBot DartBot mentioned this issue Jun 3, 2015
Closed
@anders-sandholm anders-sandholm mentioned this issue Jun 3, 2015
Closed
@vsmenon vsmenon mentioned this issue Jun 3, 2015
Closed
copybara-service bot pushed a commit that referenced this issue Dec 18, 2024
@munificent
Roll dart_style 3.0.1 into the SDK.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
04530d5 
This is a minor change with just bug fixes:

* Handle trailing commas in for-loop updaters (#1354).
* Format `||` patterns like fallthrough cases in switch expressions (#1602).
* Handle comments and metadata before variables more gracefully (#1604).
* Ensure comment formatting is idempotent (#1606).
* Better indentation of leading comments on property accesses in binary operator
  operands (#1611).
* Don't crash on doc comments in local variable declarations (#1621).

This won't affect much code, but it does change the formatting in some cases.

Change-Id: I2d52fee92aecbc24315e4f1a89360af85ec85942
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401482
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crelier crelier

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
M2
Development

No branches or pull requests
7 participants
@sethladd @dgrove @madsager @anders-sandholm @iposva-google @crelier @DartBot