Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of console.warn is unfriendly to try.dartlang.org #16001

Closed
peter-ahe-google opened this issue Jan 9, 2014 · 3 comments
Closed

Use of console.warn is unfriendly to try.dartlang.org #16001

peter-ahe-google opened this issue Jan 9, 2014 · 3 comments
Labels
area-library closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@peter-ahe-google
Copy link
Contributor

_ValidatingTreeSanitizer.sanitizeNode calls console.warn a number of times.

This is unfriendly to try.dartlang.org.

I'm not sure what is the best solution. I could monkey patch console.warn, but perhaps _ValidatingTreeSanitizer.sanitizeNode could just use print instead.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@efortuna
Copy link
Contributor

cc @blois.

@alan-knight
Copy link
Contributor

Removed Type-Defect, Priority-Unassigned labels.
Added Type-CodeHealth, Priority-Medium labels.

@peter-ahe-google peter-ahe-google added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable Priority-Medium area-library library-html labels Jan 16, 2015
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed triaged labels Mar 1, 2016
@vsmenon vsmenon added the closed-obsolete Closed as the reported issue is no longer relevant label Jul 20, 2019
@vsmenon vsmenon closed this as completed Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-library closed-obsolete Closed as the reported issue is no longer relevant library-html P2 A bug or feature request we're likely to work on type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Development

No branches or pull requests

5 participants