Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor build returns 0 even when compilation fails #15964

Closed
ricowind opened this issue Jan 8, 2014 · 12 comments
Closed

Editor build returns 0 even when compilation fails #15964

ricowind opened this issue Jan 8, 2014 · 12 comments
Assignees
@danrubel

Comments

@ricowind
Copy link
Contributor

ricowind commented Jan 8, 2014

I saw this here
http://build.chromium.org/p/client.dart/builders/dart-editor-linux-dev/builds/61/steps/dart-editor-linux-dev/logs/stdio

Compilation of the tests clearly fails.
@ricowind
Copy link
Contributor Author

ricowind commented Jan 8, 2014

Added Triaged label.

@clayberg
Copy link

clayberg commented Jan 8, 2014

Added this to the Later milestone.
Removed Priority-Unassigned label.
Added Priority-Medium label.

@devoncarew
Copy link
Member

Set owner to @danrubel.

@clayberg
Copy link

clayberg commented Apr 9, 2014

Removed this from the Later milestone.
Added this to the 1.4 milestone.

@kasperl
Copy link

kasperl commented May 8, 2014

Removed this from the 1.4 milestone.
Added this to the 1.5 milestone.

@kasperl
Copy link

kasperl commented Jun 4, 2014

Removed this from the 1.5 milestone.
Added this to the 1.6 milestone.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the 1.6 milestone.
Added Oldschool-Milestone-1.6 label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-1.6 label.

@sethladd
Copy link
Contributor

What does this impact?

@sethladd
Copy link
Contributor

Added Editor-Build label.

@ricowind
Copy link
Contributor Author

Seth: This impacts sanity :-)
There is a general assumption in all of our tools and infrastructure that if something fails you return non zero. In this specific case, the build failed for the editor, but the bots did not go red. The bots only split on the exit code: Zero, success -> green. Non-zero, failure -> red

@ricowind ricowind mentioned this issue Jun 3, 2015
Closed
@DartBot DartBot mentioned this issue Aug 6, 2015
Open
@DartBot
Copy link

DartBot commented Aug 6, 2015

This issue has been moved to dart-archive/eclipse3#21.

@DartBot DartBot closed this as completed Aug 6, 2015
@kevmoo kevmoo removed the triaged label Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danrubel danrubel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@sethladd @kevmoo @devoncarew @kasperl @danrubel @ricowind @clayberg @DartBot