Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to use at least some packages in try.dartlang.org #15945

Closed
alan-knight opened this issue Jan 7, 2014 · 7 comments
Closed

Be able to use at least some packages in try.dartlang.org #15945

alan-knight opened this issue Jan 7, 2014 · 7 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@alan-knight
Copy link
Contributor

Right now you can only import libraries in the SDK in try.dartlang.org code. That's quite limiting. I can imagine that being able to use completely arbitrary packages might run the risk of having malicious code, but it would be nice to be able to use at least a whitelisted set. For example, it'd be nice to be able to write a sample of internationalization code that could be run and played with on the site.

@peter-ahe-google
Copy link
Contributor

Eventually, try.dartlang.org should be able to import all packages published on pub.dartlang.org.

I don't know if malicious code is really a problem, or if it is something that should be addressed in a more fundamental level for try.dartlang.org.

@alan-knight
Copy link
Contributor Author

If we were to have just a snapshot of a few packages, here's a short list, compiled by looking in the pkg directory for things that look like they might plausibly work in try.dartlang.org and getting their dependencies. So, e.g. args doesn't seem that important, but it ought to work, unittest looks for it, and unittest seems useful. Analyzer seems large and less likely to be used in small snippets, but it might be and Intl requires it, though not for anything that you'd be able to do in try.dartlang.org.

  analyzer
  args
  collection
  crypto
  http
  http_parser
  intl
  logging
  markdown
  matcher
  math
  meta
  path
  serialization
  stack_trace
  string_scanner
  unittest
  yaml

@peter-ahe-google
Copy link
Contributor

App Engine is a bit annoying, but I've been able to upload packages (and then some).

You can now use the above packages at http://incr.try-dart-lang.appspot.com/.


Added Started label.

@peter-ahe-google
Copy link
Contributor

Set owner to @peter-ahe-google.

@alan-knight
Copy link
Contributor Author

Nice, thanks! It does emphasize the need to make the compile time just be proportional to the change, but it's still great to be able to do something with packages.

@peter-ahe-google
Copy link
Contributor

I've updated http://incr.try-dart-lang.appspot.com/ to also reuse package libraries. Let me know if that improves the compile times?

BTW: I don't have a meta package. Is that still relevant?

@alan-knight
Copy link
Contributor Author

Compile time much better now, 3 or 4 seconds for a trivial program using Intl.

No, meta is not relevant. I don't even know where that came from.

@sethladd sethladd closed this as completed Jun 4, 2015
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed priority-unassigned labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

4 participants