Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone VM does not compile with -Wshorten-64-to-32 #15922

Open
iposva-google opened this issue Jan 6, 2014 · 9 comments
Open

Standalone VM does not compile with -Wshorten-64-to-32 #15922

iposva-google opened this issue Jan 6, 2014 · 9 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@iposva-google
Copy link
Contributor

Found many warnings when adding the flag -Wshorten-64-to-32. Some of them are really problematic, while others just work by design (known limits to value ranges) or by accident.
@iposva-google
Copy link
Contributor Author

First round of changes on Mac here: https://codereview.chromium.org/139043003/

cc @Skabet.
Added Started label.

@andersjohnsen
Copy link

Thank you for working on this, Ivan!

@iposva-google
Copy link
Contributor Author

Fix the first round of errors being reported on the Mac. Assigning to Anders to fix the dart:io based issues. Please reassign back once they have been cleaned up.

Set owner to @Skabet.
Added Accepted label.

@andersjohnsen
Copy link

I'm unable to get to bin-compiles, as the vm still fails for both ia32 and x64. This is on Linux.

Set owner to @iposva-google.

@iposva-google
Copy link
Contributor Author

Next round of changes which should fix all VM related issues on the Mac for ia32: https://codereview.chromium.org/169893003/

Assigning this to Anders to work on the IO related failures.

@andersjohnsen
Copy link

Ivan, did you mean to reassign this to me?

@kasperl
Copy link

kasperl commented Jul 10, 2014

Added this to the 1.6 milestone.

@iposva-google
Copy link
Contributor Author

r38499 fixed a large number of failures. Getting much closer to be able to enable this for ia32 builds on Mac.

Removed this from the 1.6 milestone.
Removed Priority-High label.
Added Priority-Medium label.

@iposva-google iposva-google added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. labels Jul 25, 2014
@iposva-google iposva-google self-assigned this Jul 25, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed accepted labels Feb 29, 2016
@iposva-google iposva-google removed their assignment May 31, 2016
@a-siva a-siva removed the P2 A bug or feature request we're likely to work on label Nov 4, 2022
@a-siva
Copy link
Contributor

a-siva commented Nov 4, 2022

We are currently not working on cleaning up the code to add this option, not sure it his is a p2 issue, removing label. If anybody thinks it needs to be a p2 issue please add a comment here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @andersjohnsen @kasperl @iposva-google @a-siva