Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audiobuffersourcenode_test broken in chrome 32 roll #15913

Closed
vsmenon opened this issue Jan 6, 2014 · 6 comments
Closed

audiobuffersourcenode_test broken in chrome 32 roll #15913

vsmenon opened this issue Jan 6, 2014 · 6 comments
Assignees
@alan-knight
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@vsmenon
Copy link
Member

vsmenon commented Jan 6, 2014

This test has stopped working in the Chrome 32 roll:

FAILED: none-drt-checked release_ia32 html/audiobuffersourcenode_test/functional
Expected: Pass
Actual: RuntimeError
CommandOutput[content_shell]:

stdout:

READY

CONSOLE MESSAGE: line 78: {
  "type": "debug",
  "value": "test_controller.js started",
  "timestamp": 0
}
CONSOLE MESSAGE: line 78: {
  "type": "print",
  "value": "dart-calling-main",
  "timestamp": 0.218
}
CONSOLE MESSAGE: line 78: {
  "type": "print",
  "value": "dart-main-done",
  "timestamp": 0.261
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "dart-calling-main",
  "timestamp": 0.375
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "unittest-suite-wait-for-done",
  "timestamp": 0.376
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "dart-main-done",
  "timestamp": 0.376
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "unittest-suite-done",
  "timestamp": 0.377
}
Content-Type: text/plain
FAIL
2 ERROR Expectation: functional createBuffer. Test failed: Caught InvalidStateError: An attempt was made to use an object that is not, or is no longer, usable. (Dartium)
file:///usr/local/google/home/vsm/svn/dartium/src/out/Release/gen/blink/bindings/dart/dart/web_audio/AudioBufferSourceNode.dart 134 AudioBufferSourceNode._stop_1
file:///usr/local/google/home/vsm/svn/dartium/src/out/Release/gen/blink/bindings/dart/dart/web_audio/AudioBufferSourceNode.dart 127 AudioBufferSourceNode.stop
../../../../root_dart/tests/html/audiobuffersourcenode_test.dart 23:18 main.<fn>.<fn>
../../../../root_dart/pkg/unittest/lib/src/test_case.dart 109:30 _run.<fn>
dart:async/future_impl.dart 453 _Future._propagateToListeners.<fn>
dart:async/zone.dart 683 _rootRun
dart:async/zone.dart 832 _RootZone.run
dart:async/future_impl.dart 445 _Future._propagateToListeners
dart:async/future_impl.dart 303 _Future._complete
dart:async/future_impl.dart 354 _Future._asyncComplete.<fn>
dart:async/schedule_microtask.dart 18 _asyncRunCallback
file:///usr/local/google/home/vsm/svn/dartium/src/dart/tools/dom/src/native_DOMImplementation.dart 604 _handleMutation
Total 0 passed, 0 failed 1 errors
@vsmenon
Copy link
Member Author

vsmenon commented Jan 7, 2014

This is breaking on dart2js as well. We need to investigate if this test is still valid. I've updated the status to mark as fail for drt. It'll likely go red on Chrome bots when they go to 32.

Removed Area-Dartium label.
Added Area-HTML label.

@vsmenon
Copy link
Member Author

vsmenon commented Jan 7, 2014

Here's the dart2js error:

FAILED: dart2js-drt release_ia32 html/audiobuffersourcenode_test/functional
Expected: Pass
Actual: RuntimeError
CommandOutput[dart2js]:
CommandOutput[content_shell]:

stdout:
#READY
CONSOLE MESSAGE: line 78: {
  "type": "debug",
  "value": "test_controller.js started",
  "timestamp": 0
}
CONSOLE MESSAGE: line 78: {
  "type": "print",
  "value": "dart-calling-main",
  "timestamp": 0.397
}
CONSOLE MESSAGE: line 78: {
  "type": "print",
  "value": "dart-main-done",
  "timestamp": 0.454
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "dart-calling-main",
  "timestamp": 0.46
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "unittest-suite-wait-for-done",
  "timestamp": 0.46
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "dart-main-done",
  "timestamp": 0.577
}
CONSOLE MESSAGE: line 78: {
  "type": "message_received",
  "value": "unittest-suite-done",
  "timestamp": 0.582
}
Content-Type: text/plain
FAIL
2 ERROR Expectation: functional createBuffer. Test failed: Caught InvalidStateError: Failed to execute 'stop' on 'OscillatorNode': cannot call stop without calling start first.
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 383:16 main__closure0.call$0
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 12558:32 TestCase.testFunction$0
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 12683:17 TestCase__run_closure0.call$1
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 4493:34 _Future._onValue$1
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 4784:44 _Future__propagateToListeners_closure0.call$0
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 4409:16 dart._rootRun
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 4698:13 dart._Future.static._Future__propagateToListeners
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 4581:9 _Future._complete$1
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 4761:19 _Future__asyncComplete_closure.call$0
../../../generated_compilations/dart2js-sdk/tests_html_audiobuffersourcenode_test/test.js 4293:18 _asyncRunCallback
Total 0 passed, 0 failed 1 errors
PASS
#EOF
#EOF

@blois
Copy link
Contributor

blois commented Jan 13, 2014

Appears to be two issues here- stop being called when the stream isn't playing, and an error being printed out for audio under Linux (fixed with http://src.chromium.org/viewvc/chrome?view=revision&revision=236632).

Set owner to @blois.
Added Accepted label.

@kevmoo
Copy link
Member

kevmoo commented Apr 7, 2014

Removed Area-HTML label.
Added Area-Library, Library-Html labels.

@alan-knight
Copy link
Contributor

This seems to be ok now - at least the tests pass when I un-suppress them.

Re-enabling the tests on chrome/dartium in https://codereview.chromium.org/880363003

Set owner to @alan-knight.
Added Started label.

@vsmenon vsmenon added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-html labels Jan 29, 2015
@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
@matanlurey
Copy link
Contributor

I'm guessing we no longer care about ContentShell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alan-knight alan-knight

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-obsolete Closed as the reported issue is no longer relevant library-html type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kevmoo @matanlurey @vsmenon @blois @alan-knight