Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve/warns_on_assets_paths_test is failing on the Windows bot, but not locally #15741

Closed
munificent opened this issue Dec 19, 2013 · 5 comments
Labels
area-infrastructure type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@munificent
Copy link
Member

I just checked in a new test for pub. It passes everywhere, including on my local Windows machine. But it's failing on the bot with:

 Results of running 'pub serve':
  Process exited with exit code -1.
  Standard output:
  | MSG : Serving myapp on http://127.0.0.1:59461
  | MSG : Build completed successfully
  Standard error:
  | FINE: Pub 0.1.2+3
  | IO : Spawning cmd /c ver
  | IO : Finished ver. Exit code 0.stdout:Microsoft Windows [Version 6.1.7601]Nothing output on stderr.
  | IO : Listing directory C:\Users\CHROME2\AppData\Local\Temp\pub_3ddf4566-68f5-11e3-adfc-005056030208\myapp\web.
  | IO : Listing directory C:\Users\CHROME
2\AppData\Local\Temp\pub_3ddf4566-68f5-11e3-adfc-005056030208\myapp\web\foo.
  | IO : Listing directory C:\Users\CHROME~2\AppData\Local\Temp\pub_3ddf4566-68f5-11e3-adfc-005056030208\myapp\web\foo\assets.

I didn't think a negative exit code was even possible. As you can see, no exception is thrown. It looks like the process just dies.

http://chromegw.corp.google.com/i/client.dart/builders/pub-win-be/builds/2695/steps/pub%20tests/logs/stdio

Any idea what's going on here?

@mkustermann
Copy link
Member

AFAIK dart:io gets an 32bit unsigned integer for the exit code and casts it to a signed 32bit integer.
See the bleeding_edge docs for it:
https://api.dartlang.org/docs/channels/be/latest/dart_io/Process.html#exitCode


cc @sgjesse.

@anders-sandholm
Copy link
Contributor

Added Area-Infrastructure label.

@ricowind
Copy link
Contributor

ricowind commented Jan 8, 2014

Bob:
Could you just get Emily to log you into the bot and see if you can repro there?


cc @efortuna.

@munificent
Copy link
Member Author

I don't think repro-ing this is the issue. After all, the Windows bot consistently repros it everytime it runs the test. The challenge is fixing it. There's no code in pub that outputs a negative (or 255) exit code that I'm aware of, so I believe this problem is coming from under pub either in dart:io or elsewhere in the VM.

@kevmoo kevmoo added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed priority-unassigned labels Feb 29, 2016
@srawlins
Copy link
Member

Neither pub serve nor pub build are valid commands any more.

$ pub serve
Dart 2 has a new build system. Learn how to migrate from pub build and
pub serve: https://webdev.dartlang.org/dart-2

$ pub build
Dart 2 has a new build system. Learn how to migrate from pub build and
pub serve: https://webdev.dartlang.org/dart-2

$ pub --version
Pub 2.0.0-dev.63.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

6 participants