Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-arg method hint request #15710

Closed
stevemessick opened this issue Dec 18, 2013 · 8 comments
Closed

No-arg method hint request #15710

stevemessick opened this issue Dec 18, 2013 · 8 comments
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug

Comments

@stevemessick
Copy link
Contributor

I wish there was a hint that told me when I had a method with no arguments and I was just closurizing it and throwing the result away rather than calling it.

Alan Knight
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.1.0.edge_031147 (2013-12-13)
OS: Mac OS X - x86_64 (10.9)
JVM: 1.6.0_65

projects: 6

open dart files: 63

auto-run pub: false
localhost resolves to: 127.0.0.1
mem max/total/free: 1983 / 1049 / 407 MB
thread count: 70
index: 1203850 relationships in 218639 keys in -7715 sources

SDK installed: true
Dartium installed: true

@stevemessick
Copy link
Contributor Author


Attachment:
screenshot.png (333.36 KB)

@clayberg
Copy link

clayberg commented Apr 1, 2014

Added Analyzer-Hint label.

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@stevemessick stevemessick added Type-Enhancement area-analyzer analyzer-warning Issues with the analyzer's Warning codes labels Aug 4, 2014
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug and removed triaged labels Mar 1, 2016
@bwilkerson bwilkerson added analyzer-linter Issues with the analyzer's support for the linter package and removed analyzer-warning Issues with the analyzer's Warning codes labels Aug 15, 2016
@bwilkerson bwilkerson removed their assignment Aug 15, 2016
@matanlurey matanlurey added the closed-obsolete Closed as the reported issue is no longer relevant label Jun 19, 2018
@srawlins srawlins reopened this Jun 21, 2018
@srawlins
Copy link
Member

I still think we should have a lint for this.

@srawlins srawlins removed the closed-obsolete Closed as the reported issue is no longer relevant label Jun 21, 2018
@zoechi
Copy link
Contributor

zoechi commented Jun 22, 2018

Work in progress dart-lang/linter#1014 (comment)
I haven't found the new PR @davidmorgan mentioned.

This was previously part of dart-lang/linter#1019 but was removed to become its own lint.

@davidmorgan
Copy link
Contributor

Actually the decision was to keep it part of unnecessary_statements, and make unnecessary_statements more useful by fixing up some false positives.

So the answer to this issue should be just, the lint is unnecessary_statements :)

@pq
Copy link
Member

pq commented Jun 27, 2018

Closing here in favor of follow-up on the linter (and unnecessary_statements).

Thanks!

@pq pq closed this as completed Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-linter Issues with the analyzer's support for the linter package area-analyzer P2 A bug or feature request we're likely to work on type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

10 participants