Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakpoint moves to strange lines #15634

Closed
stevemessick opened this issue Dec 13, 2013 · 9 comments
Closed

breakpoint moves to strange lines #15634

stevemessick opened this issue Dec 13, 2013 · 9 comments
Assignees
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@stevemessick
Copy link
Contributor

Breakpoints getting out of sync. I have a breakpoint set in comment.dart, on line 101, inside an if statement that I put there so I could have a breakpoint. It's shown in the text editor. When the program runs it does indeed print "foo". When I look at the list of breakpoints, I see two active breakpoints in comment.dart, on the same line, 189. The file is 126 lines long.

Alan Knight
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.1.0.edge_031110 (2013-12-12)
OS: Mac OS X - x86_64 (10.9)
JVM: 1.6.0_65

projects: 6

open dart files: 56

auto-run pub: false
localhost resolves to: 127.0.0.1
mem max/total/free: 1983 / 636 / 329 MB
thread count: 54
index: 1204090 relationships in 213068 keys in 558 sources

SDK installed: true
Dartium installed: true


Attachment:
screenshot.png (338.08 KB)

@stevemessick
Copy link
Contributor Author

Further to my previous feedback, note the messages when I try to set or unset the breakpoint. [breakpoint in comment.dart moved from line 101 to 189]. Which does not exist.

Alan Knight
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.1.0.edge_031110 (2013-12-12)
OS: Mac OS X - x86_64 (10.9)
JVM: 1.6.0_65

projects: 6

open dart files: 56

auto-run pub: false
localhost resolves to: 127.0.0.1
mem max/total/free: 1983 / 636 / 301 MB
thread count: 44
index: 1204090 relationships in 213068 keys in 558 sources

SDK installed: true
Dartium installed: true


Attachment:
screenshot.png (338.16 KB)

@stevemessick
Copy link
Contributor Author

Still further feedback on breakpoints moving. The problem survives both re-analyzing and restarting the editor. The problem starts at line 28. Breakpoints prior to that point are inserted at their correct position. A breakpoint on the factory constructor on line 28 gets moved. Source for the first bit attached. The entire project is dartdoc-viewer on github in web/client/comment.dart

Alan Knight

// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

library web.comment;

import 'dart:html';
import 'dart:js' as js;
import 'package:dartdoc_viewer/item.dart';
import 'package:dartdoc_viewer/location.dart';
import 'package:dartdoc_viewer/search.dart' show searchIndex;
import 'package:polymer/polymer.dart';
import 'app.dart' show viewer;
import 'member.dart';

ourBreakpointsSuck() {
  print("asdfasdf");
}

// TODO(jmesserly): extend section once this bug is fixed?
// https://codereview.chromium.org/90113002/
@CustomTag('dartdoc-comment')
class CommentElement extends DivElement with Polymer, Observable {
  @­published Container item;
  @­published bool preview = false;
  Element _commentElement;

  factory CommentElement() => new Element.tag('div', 'dartdoc-comment');
////////////////////////////////////////////////////////////////////////////////////
Editor: 1.1.0.edge_031110 (2013-12-12)
OS: Mac OS X - x86_64 (10.9)
JVM: 1.6.0_65

projects: 6

open dart files: 56

auto-run pub: false
localhost resolves to: 127.0.0.1
mem max/total/free: 1983 / 438 / 121 MB
thread count: 35
index: 1202498 relationships in 212763 keys in 949 sources

SDK installed: true
Dartium installed: true

@devoncarew
Copy link
Member

Removed this from the 1.2 milestone.
Added this to the Later milestone.

@devoncarew
Copy link
Member

I can repo this using the editor and using devtools. Setting a breakpoint in comment.dart line 43 moves the breakpoint to line 72.

[40044.254==>{"id":11,"method":"Debugger.setBreakpointByUrl","params":{"urlRegex":"client/web/comment.dart","lineNumber":42}}]
[40044.277<=={"id":11,"result":{"locations":[{"lineNumber":71,"scriptId":"-865","columnNumber":0}],"breakpointId":"/client/web/comment.dart/:42:0"}}]

You should be able to break on line 43. Not sure why the VM decides to move the breakpoint so far down the file.


cc @mhausner.
Set owner to @jacob314.
Removed Area-Editor label.
Added Area-Dartium label.
Changed the title to: "breakpoint moves to strange lines".

@DartBot
Copy link

DartBot commented Jan 20, 2014

This comment was originally written by jora...@gmail.com


I have to same problem and in some file, I just can't debug because the debugger is in the wrong function. It happen in both, Dartium and dart editor using the latest 1.1.1 STABLE.

@DartBot
Copy link

DartBot commented Feb 21, 2014

This comment was originally written by corneli...@pcornelissen.de


I'm having the same issues with 1.1.3 and dartium on linux. I think it worked before with an older version, but I don't know what triggered the bug...

@kasperl
Copy link

kasperl commented Jul 10, 2014

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

@kasperl
Copy link

kasperl commented Aug 4, 2014

Removed Oldschool-Milestone-Later label.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) and removed triaged labels Mar 1, 2016
@mhausner mhausner added the closed-obsolete Closed as the reported issue is no longer relevant label Jan 24, 2017
@mhausner
Copy link
Contributor

Breakpoint resolution has long been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

7 participants